Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding keyboard: tkl30 #7979

Merged
merged 6 commits into from
Feb 7, 2020
Merged

adding keyboard: tkl30 #7979

merged 6 commits into from
Feb 7, 2020

Conversation

worldspawn00
Copy link
Contributor

Description

adding keyboard: tkl30

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace include guards with #pragma once
Replace atomic bootloader options with BOOTLOADER = caterina
Remove firmware filesize changes from rules.mk

@ridingqwerty
Copy link
Contributor

Applied collaborator suggestions, requesting a second look from @noroadsleft

@ridingqwerty
Copy link
Contributor

Committed recent suggestions by @noroadsleft

@noroadsleft noroadsleft merged commit e43d143 into qmk:master Feb 7, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 7, 2020
* 'master' of https://github.com/qmk/qmk_firmware:
  [Keyboard] adding keyboard: tkl30 (qmk#7979)
  Move Grave Escape, Lock and Leader keycodes into their own sect… (qmk#8093)
  Committing fix to info.json for wsk/jerkin (qmk#8110)
  Use function for KEYCODE2 routines instead of macro. (qmk#8101)
  [keyboard] adding keyboard: jerkin (qmk#7975)
  Ergosaurus Configurator support bugfix (qmk#8104)
  Xelus Dawn60: layout macro update and Configurator layout support (qmk#8102)
  VIA Support: 1upkeyboards 1up60rgb (qmk#8097)
  [Keymap] User keymap for AKB/Raine (qmk#8081)
  VIA Support: KBD67 mkii v1/v2 (qmk#8085)
  fixup keymap for 65_ansi_blocker (qmk#8099)
  [Keyboard] manta60 (qmk#8068)
  [Keyboard] add Infinity CE (qmk#8067)
  [Keyboard] Added Atreus Pro Micro variant (qmk#8059)
  Add Uni660 Keyboard (qmk#8018)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* tkl30

* Amended with collaborator suggestions

* s/DEBOUNCING_DELAY/DEBOUNCE/

* Used noroadsleft's PID suggestion

* Committed noroadsleft's keymap formatting and rules.mk suggestions

* LAYOUT formatting and readme suggestions
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* tkl30

* Amended with collaborator suggestions

* s/DEBOUNCING_DELAY/DEBOUNCE/

* Used noroadsleft's PID suggestion

* Committed noroadsleft's keymap formatting and rules.mk suggestions

* LAYOUT formatting and readme suggestions
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* tkl30

* Amended with collaborator suggestions

* s/DEBOUNCING_DELAY/DEBOUNCE/

* Used noroadsleft's PID suggestion

* Committed noroadsleft's keymap formatting and rules.mk suggestions

* LAYOUT formatting and readme suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants