Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New keyboard]manta60 #8068

Merged
merged 16 commits into from
Feb 5, 2020
Merged

[New keyboard]manta60 #8068

merged 16 commits into from
Feb 5, 2020

Conversation

KamoNanban
Copy link
Contributor

Description

A split keyboard with 27 ortholinear keys and 5-7 thumb/little finger keys
68 RGB_LEDs can be optionally installed

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team February 2, 2020 19:36
@KamoNanban
Copy link
Contributor Author

Thank you. I fixed.
@drashna
@noroadsleft
@mechmerlin

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from drashna February 3, 2020 21:21
Comment on lines 10 to 12
ifeq ($(strip $(IOS_DEVICE_ENABLE)), yes)
OPT_DEFS += -DIOS_DEVICE_ENABLE
endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the keyboard-level rules.mk.

@KamoNanban
Copy link
Contributor Author

Thank you drashna and fauxpark !

KamoNanban and others added 4 commits February 5, 2020 20:45
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@KamoNanban
Copy link
Contributor Author

Thank you!
@fauxpark

@drashna
Copy link
Member

drashna commented Feb 5, 2020

Thanks!

@drashna drashna merged commit 9fe0c87 into qmk:master Feb 5, 2020
@KamoNanban KamoNanban deleted the new_keyboard_manta60 branch February 6, 2020 13:14
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 7, 2020
* 'master' of https://github.com/qmk/qmk_firmware:
  [Keyboard] adding keyboard: tkl30 (qmk#7979)
  Move Grave Escape, Lock and Leader keycodes into their own sect… (qmk#8093)
  Committing fix to info.json for wsk/jerkin (qmk#8110)
  Use function for KEYCODE2 routines instead of macro. (qmk#8101)
  [keyboard] adding keyboard: jerkin (qmk#7975)
  Ergosaurus Configurator support bugfix (qmk#8104)
  Xelus Dawn60: layout macro update and Configurator layout support (qmk#8102)
  VIA Support: 1upkeyboards 1up60rgb (qmk#8097)
  [Keymap] User keymap for AKB/Raine (qmk#8081)
  VIA Support: KBD67 mkii v1/v2 (qmk#8085)
  fixup keymap for 65_ansi_blocker (qmk#8099)
  [Keyboard] manta60 (qmk#8068)
  [Keyboard] add Infinity CE (qmk#8067)
  [Keyboard] Added Atreus Pro Micro variant (qmk#8059)
  Add Uni660 Keyboard (qmk#8018)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* manta60_update

* Update config.h

* Update config.h

* Update config.h

* Fixed info and readme

* Fixed config.h

* Fixed rules.mk

* Fixed keymap.c

* Update keyboards/manta60/rules.mk

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Fixed keymap.c

* Fixed rules.mk

* Update rules.mk

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: fauxpark <fauxpark@gmail.com>
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* manta60_update

* Update config.h

* Update config.h

* Update config.h

* Fixed info and readme

* Fixed config.h

* Fixed rules.mk

* Fixed keymap.c

* Update keyboards/manta60/rules.mk

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Fixed keymap.c

* Fixed rules.mk

* Update rules.mk

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: fauxpark <fauxpark@gmail.com>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* manta60_update

* Update config.h

* Update config.h

* Update config.h

* Fixed info and readme

* Fixed config.h

* Fixed rules.mk

* Fixed keymap.c

* Update keyboards/manta60/rules.mk

Co-Authored-By: Drashna Jaelre <drashna@live.com>

* Fixed keymap.c

* Fixed rules.mk

* Update rules.mk

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/manta60/keymaps/default/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: fauxpark <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants