Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Atreus Pro Micro variant #8059

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Added Atreus Pro Micro variant #8059

merged 6 commits into from
Feb 5, 2020

Conversation

ibnuda
Copy link
Contributor

@ibnuda ibnuda commented Feb 1, 2020

Description

  • Added cheap promicro clone as one of the alternative controllers, intended to be used with this fork.
  • Added my personal keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft requested changes Feb 1, 2020
View reviewed changes
keyboards/atreus/keymaps/ibnuda/config.h Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/rules.mk Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested review from zvecr and a team February 1, 2020 21:18
@noroadsleft noroadsleft changed the title new alternative controller. Added Atreus Pro Micro variant Feb 1, 2020
drashna
drashna reviewed Feb 2, 2020
View reviewed changes
keyboards/atreus/readme.md Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Board level stuff looks good, just this one little thing jumps out right now

keyboards/atreus/keymaps/ibnuda/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Feb 5, 2020
View reviewed changes
keyboards/atreus/keymaps/ibnuda/keymap.c Outdated Show resolved Hide resolved
keyboards/atreus/keymaps/ibnuda/config.h Outdated Show resolved Hide resolved
keyboards/atreus/promicro/config.h Show resolved Hide resolved
@noroadsleft noroadsleft merged commit fb980cf into qmk:master Feb 5, 2020
@noroadsleft
Copy link
Member

Thanks!

@ibnuda ibnuda deleted the atrpro branch February 5, 2020 17:26
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 7, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
1bc1ccb 
* 'master' of https://github.com/qmk/qmk_firmware:
  [Keyboard] adding keyboard: tkl30 (qmk#7979)
  Move Grave Escape, Lock and Leader keycodes into their own sect… (qmk#8093)
  Committing fix to info.json for wsk/jerkin (qmk#8110)
  Use function for KEYCODE2 routines instead of macro. (qmk#8101)
  [keyboard] adding keyboard: jerkin (qmk#7975)
  Ergosaurus Configurator support bugfix (qmk#8104)
  Xelus Dawn60: layout macro update and Configurator layout support (qmk#8102)
  VIA Support: 1upkeyboards 1up60rgb (qmk#8097)
  [Keymap] User keymap for AKB/Raine (qmk#8081)
  VIA Support: KBD67 mkii v1/v2 (qmk#8085)
  fixup keymap for 65_ansi_blocker (qmk#8099)
  [Keyboard] manta60 (qmk#8068)
  [Keyboard] add Infinity CE (qmk#8067)
  [Keyboard] Added Atreus Pro Micro variant (qmk#8059)
  Add Uni660 Keyboard (qmk#8018)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@ibnuda @HokieGeek
[Keyboard] Added Atreus Pro Micro variant (qmk#8059)
4af54ab 
* new alternative controller.

* following suggestions at qmk's 8059.

* forgot to replace some underscores and keycodes.

* following drashna's suggestions at qmk's 8059.

* following zvecr's suggestion in qmk's 8059.

* following noroadsleft's suggestion at qmk's 8059.
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@ibnuda @c0psrul3
[Keyboard] Added Atreus Pro Micro variant (qmk#8059)
69a5670 
* new alternative controller.

* following suggestions at qmk's 8059.

* forgot to replace some underscores and keycodes.

* following drashna's suggestions at qmk's 8059.

* following zvecr's suggestion in qmk's 8059.

* following noroadsleft's suggestion at qmk's 8059.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@ibnuda @kujawakk
[Keyboard] Added Atreus Pro Micro variant (qmk#8059)
5e8f3c6 
* new alternative controller.

* following suggestions at qmk's 8059.

* forgot to replace some underscores and keycodes.

* following drashna's suggestions at qmk's 8059.

* following zvecr's suggestion in qmk's 8059.

* following noroadsleft's suggestion at qmk's 8059.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@zvecr zvecr zvecr requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ibnuda @noroadsleft @drashna @fauxpark @zvecr