Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User keymap for AKB/Raine #8081

Merged
merged 8 commits into from
Feb 5, 2020
Merged

User keymap for AKB/Raine #8081

merged 8 commits into from
Feb 5, 2020

Conversation

plikki
Copy link
Contributor

@plikki plikki commented Feb 4, 2020

Description

This request is for a user made keymap for the Raine keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

plikki added 4 commits February 4, 2020 10:27
@plikki
Adding my keymap
0e842a3 
Adding a personalized keymap to the Raine keyboard. This diffirentiates itself by being useble with nordic characters even when the bottom row has blockers. Also added ASCII art to help visualize what you are doing when programming the board.
@plikki
Update Readme.md
7e99e18 
Ned image of the board
@plikki
Update Readme.md
0fb9dd0 
Forgot a space in Readme
@plikki
Update Readme.md
5648307 
And another missed space
@drashna drashna requested a review from a team February 5, 2020 02:44
@plikki
Update keymap.c
7d9d5d2 
Renoved Definetion that is not used
fauxpark
fauxpark requested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the keymap folder name and "Readme.md" to lowercase?

plikki added 3 commits February 5, 2020 15:33
@plikki
Update Readme.md
5de3fb2
@plikki
Remove files for renaming
b4211fe
@plikki
Adding files after renaming
b32c750 
Was unable to get Girthub to push renamed files/folders. Therefore removeing and adding them again.
@plikki
Copy link
Contributor Author

plikki commented Feb 5, 2020

Hello!
Sorry for the removing and adding files, but i did not seem to be able to rename files through github desktop, nor via the command line.

Thank you for letting me know that the naming was wrong, i must have missed that somewhere, they have been updated to be lowercase

Best Regards

@fauxpark fauxpark requested a review from a team February 5, 2020 14:55
@drashna
Copy link
Member

drashna commented Feb 5, 2020

Renaming can be tricky. For command line, if you name it to something different, commit, and then name it back, but lowercase and commit, that will pick up the change.

@drashna drashna requested a review from a team February 5, 2020 17:16
noroadsleft
noroadsleft approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

If you need any help with this just ask.

Thanks for your contribution!

@noroadsleft noroadsleft merged commit 78ae77f into qmk:master Feb 5, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 7, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
1bc1ccb 
* 'master' of https://github.com/qmk/qmk_firmware:
  [Keyboard] adding keyboard: tkl30 (qmk#7979)
  Move Grave Escape, Lock and Leader keycodes into their own sect… (qmk#8093)
  Committing fix to info.json for wsk/jerkin (qmk#8110)
  Use function for KEYCODE2 routines instead of macro. (qmk#8101)
  [keyboard] adding keyboard: jerkin (qmk#7975)
  Ergosaurus Configurator support bugfix (qmk#8104)
  Xelus Dawn60: layout macro update and Configurator layout support (qmk#8102)
  VIA Support: 1upkeyboards 1up60rgb (qmk#8097)
  [Keymap] User keymap for AKB/Raine (qmk#8081)
  VIA Support: KBD67 mkii v1/v2 (qmk#8085)
  fixup keymap for 65_ansi_blocker (qmk#8099)
  [Keyboard] manta60 (qmk#8068)
  [Keyboard] add Infinity CE (qmk#8067)
  [Keyboard] Added Atreus Pro Micro variant (qmk#8059)
  Add Uni660 Keyboard (qmk#8018)
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@plikki @HokieGeek
[Keymap] User keymap for AKB/Raine (qmk#8081)
1fe33a6 
* Adding my keymap

Adding a personalized keymap to the Raine keyboard. This diffirentiates itself by being useble with nordic characters even when the bottom row has blockers. Also added ASCII art to help visualize what you are doing when programming the board.

* Update Readme.md

Ned image of the board

* Update Readme.md

Forgot a space in Readme

* Update Readme.md

And another missed space

* Update keymap.c

Renoved Definetion that is not used

* Update Readme.md

* Remove files for renaming

* Adding files after renaming

Was unable to get Girthub to push renamed files/folders. Therefore removeing and adding them again.
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@plikki @c0psrul3
[Keymap] User keymap for AKB/Raine (qmk#8081)
75b9a5d 
* Adding my keymap

Adding a personalized keymap to the Raine keyboard. This diffirentiates itself by being useble with nordic characters even when the bottom row has blockers. Also added ASCII art to help visualize what you are doing when programming the board.

* Update Readme.md

Ned image of the board

* Update Readme.md

Forgot a space in Readme

* Update Readme.md

And another missed space

* Update keymap.c

Renoved Definetion that is not used

* Update Readme.md

* Remove files for renaming

* Adding files after renaming

Was unable to get Girthub to push renamed files/folders. Therefore removeing and adding them again.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@plikki @kujawakk
[Keymap] User keymap for AKB/Raine (qmk#8081)
fe7c049 
* Adding my keymap

Adding a personalized keymap to the Raine keyboard. This diffirentiates itself by being useble with nordic characters even when the bottom row has blockers. Also added ASCII art to help visualize what you are doing when programming the board.

* Update Readme.md

Ned image of the board

* Update Readme.md

Forgot a space in Readme

* Update Readme.md

And another missed space

* Update keymap.c

Renoved Definetion that is not used

* Update Readme.md

* Remove files for renaming

* Adding files after renaming

Was unable to get Girthub to push renamed files/folders. Therefore removeing and adding them again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@plikki @drashna @fauxpark @noroadsleft @mechmerlin