Xelus Dawn60: layout macro update and Configurator layout support #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K2D switch position is actually physically on the top row, as the right half of a split Backspace.
fauxpark
approved these changes
Feb 5, 2020
zvecr
approved these changes
Feb 6, 2020
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Feb 7, 2020
* 'master' of https://github.com/qmk/qmk_firmware: [Keyboard] adding keyboard: tkl30 (qmk#7979) Move Grave Escape, Lock and Leader keycodes into their own sect… (qmk#8093) Committing fix to info.json for wsk/jerkin (qmk#8110) Use function for KEYCODE2 routines instead of macro. (qmk#8101) [keyboard] adding keyboard: jerkin (qmk#7975) Ergosaurus Configurator support bugfix (qmk#8104) Xelus Dawn60: layout macro update and Configurator layout support (qmk#8102) VIA Support: 1upkeyboards 1up60rgb (qmk#8097) [Keymap] User keymap for AKB/Raine (qmk#8081) VIA Support: KBD67 mkii v1/v2 (qmk#8085) fixup keymap for 65_ansi_blocker (qmk#8099) [Keyboard] manta60 (qmk#8068) [Keyboard] add Infinity CE (qmk#8067) [Keyboard] Added Atreus Pro Micro variant (qmk#8059) Add Uni660 Keyboard (qmk#8018)
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…k#8102) * fix layout macro and update keymaps K2D switch position is actually physically on the top row, as the right half of a split Backspace. * add QMK Configurator layout support
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
…k#8102) * fix layout macro and update keymaps K2D switch position is actually physically on the top row, as the right half of a split Backspace. * add QMK Configurator layout support
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…k#8102) * fix layout macro and update keymaps K2D switch position is actually physically on the top row, as the right half of a split Backspace. * add QMK Configurator layout support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered the layout macro didn't conform to QMK conventions when I was about to add a default keymap for this board to QMK Configurator. Updated the layout macro and both the
defaultandviakeymaps accordingly. Also compiled both before and after to make sure these changes don't change the behaviour of anything.@Xelus22 kindly gave permission to make these changes.
Types of Changes
Checklist