🏛 fix: quiet logs when linting in CI

[estrattonbailey]

Fixes RNBW-4331

What changed (plus any additional context for devs)

With the new ESLint setup, we have >4k warnings. These only useful when commiting changes locally via the lint-staged pre-commit git hook. In CI, we should only surface errors. This is what the --quiet option does.

Since yarn's handling of passed arguments to npm scripts might not be clear to everyone, I opted to spell out the whole command in the GitHub Action instead of yarn lint --quiet.

Final checklist

• Assigned individual reviewers?
• Added labels? (team1/team2, critical path, release, dev QA)
• Did you test both iOS and Android?
• If your changes are visual, did you check both the light and dark themes?
• Added e2e tests? If not, please specify why
• If you added new critical path files, did you update the CODEOWNERS file?
• If no dev QA label, did you add the PR to the QA Queue?

[linear]

RNBW-4331 Use recommended ESLint settings

At the moment we've manually configured ESLint rules (almost 400 lines worth) and ignored the recommended settings. This is swallowing a handful of errors that really should not be ignored, like:

• @typescript-eslint/no-non-null-asserted-optional-chain which is dangerous and can lead to bugs like RNBW-4283
• @typescript-eslint/ban-types where we mix up Boolean and boolean etc
• no-async-promise-executor where we have async functions within Promise which is already async, and can lead to race conditions
• @typescript-eslint/no-unnecessary-type-constraint which might alter the call signature of a function in unexpected ways
• error on no-useless-catch because usually we're doing this to capture an error and we should capture an error
• @typescript-eslint/ban-ts-comment which should be set to warn so that we can work towards full type coverage
• no-dupe-if-else is an important one to throw, and we were swallowing it
• sorting our keys is a waste of time — we had over 70 overrides, see commit — if we really want this we should have prettier do it

Based on my tinkering, we can improve this situation fairly quickly.

RNBW-4371 Use `--quiet` option when linting in CI

[skylarbarrera]

🏛️