analytics: add tracking for screen dimensions + fix nav events on android #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
reviewed
Aug 29, 2022
|
TEAM2-485 Add tracking for device dimensions TEAM2-486 Fix navigation route analytics on android
currently not triggering events except for the expanded asset sheet |
|
I would add, just in case, "screen" too |
terrysahaidak
approved these changes
Sep 2, 2022
estebanmino
approved these changes
Sep 2, 2022
estrattonbailey
added a commit
that referenced
this pull request
Sep 6, 2022
…w-4378-clean-up-global-and-env-vars-in-app-move * 'develop' of github.com:rainbow-me/rainbow: (40 commits) fix: quiet logs when linting in CI (#4070) analytics: add tracking for screen dimensions + fix nav events on android (#4088) fix native input cursor color (#4112) Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046) chore: upgrade eslint-config-rainbow (#4118) backup PIN (#4012) Remove long press on address in switching wallets (#3990) Version bump iOS v.1.7.4 & Android 144 (#4117) Fix slow image loading (#4052) Add new text size scale, deprecate old sizes and Heading (#4113) Disable campaings in e2e and fix testID of PromoSheet (#4107) 🏛 chore: prettier everything (#4100) fix settings StatusIcon shadows on android (#4104) fix clear async storage crash (#4105) fix RNBW-4416 (#4103) 🏛 Update to React Query 4 (#4060) swaps: init cross chain feature flag (#4091) enable arbiitrum swap details test (#4092) remove unsafe access to networkInfo (#4096) network check (#4094) ...
estrattonbailey
added a commit
that referenced
this pull request
Sep 6, 2022
…w-4388-configure-jest-for-unit-tests * 'develop' of github.com:rainbow-me/rainbow: Profiles: Support contenthash (#4067) 🏛 GraphQL Clients/Codegen Foundations (#4086) fix: quiet logs when linting in CI (#4070) analytics: add tracking for screen dimensions + fix nav events on android (#4088) fix native input cursor color (#4112) Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046) chore: upgrade eslint-config-rainbow (#4118) backup PIN (#4012) Remove long press on address in switching wallets (#3990) Version bump iOS v.1.7.4 & Android 144 (#4117) Fix slow image loading (#4052) Add new text size scale, deprecate old sizes and Heading (#4113)
estebanmino
pushed a commit
that referenced
this pull request
Sep 9, 2022
…roid (#4088) * add tracking for screen dimensions * rm very bad android check * better tracking * window -> screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TEAM2-485 TEAM2-486
What changed (plus any additional context for devs)
we want to run some analysis on our user's device sizes so I've added to the user identity.
I also fixed a glaring issue where navigation state changes were not being tracked on android
Screen recordings / screenshots
N/A
What to test
should be a no-op
Final checklist
team1/team2,critical path,release,dev QA)dev QAlabel, did you add the PR to the QA Queue?