swaps: init cross chain feature flag #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEAM2-456 Cross-chain & bridging feature flag
To progressively build the feature on top of swaps feature we'll need a flag to allow cross chain swaps and bridging.
|
skylarbarrera
added
swap-aggregator
estebanmino
reviewed
Aug 29, 2022
estebanmino
reviewed
Aug 29, 2022
estebanmino
reviewed
Aug 29, 2022
estebanmino
reviewed
Aug 29, 2022
| @@ -22,6 +23,7 @@ export const defaultConfig = { | |||
| [NOTIFICATIONS]: { needsRestart: true, settings: true, value: false }, | |||
| [PROFILES]: { settings: true, value: true }, | |||
| [REVIEW_ANDROID]: { settings: false, value: false }, | |||
| [CROSSCHAIN_SWAPS]: { settings: true, value: false }, | |||
There was a problem hiding this comment.
i think having just this is perfect for now, then when we start adding new stuff on top we can use the flag more broadly
This reverts commit 12cff26.
derHowie
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
dev qa pass
off: https://recordit.co/gJ3CS3zicW
on: https://recordit.co/SeBbxHYs9J
estrattonbailey
added a commit
that referenced
this pull request
Sep 6, 2022
…w-4378-clean-up-global-and-env-vars-in-app-move * 'develop' of github.com:rainbow-me/rainbow: (40 commits) fix: quiet logs when linting in CI (#4070) analytics: add tracking for screen dimensions + fix nav events on android (#4088) fix native input cursor color (#4112) Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046) chore: upgrade eslint-config-rainbow (#4118) backup PIN (#4012) Remove long press on address in switching wallets (#3990) Version bump iOS v.1.7.4 & Android 144 (#4117) Fix slow image loading (#4052) Add new text size scale, deprecate old sizes and Heading (#4113) Disable campaings in e2e and fix testID of PromoSheet (#4107) 🏛 chore: prettier everything (#4100) fix settings StatusIcon shadows on android (#4104) fix clear async storage crash (#4105) fix RNBW-4416 (#4103) 🏛 Update to React Query 4 (#4060) swaps: init cross chain feature flag (#4091) enable arbiitrum swap details test (#4092) remove unsafe access to networkInfo (#4096) network check (#4094) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TEAM2-456
Figma link (if any):
What changed (plus any additional context for devs)
created the feature flag for cross chain swaps/bridging
I also feature flagged off some logic that is specific to the v1 implementation so it doesn't get in the way of future development
Screen recordings / screenshots
settings: https://cloud.skylarbarrera.com/Screen-Shot-2022-08-29-10-24-01.79.png
toggled off behavior:
before: https://cloud.skylarbarrera.com/Screen-Recording-2022-08-29-10-17-18.mp4
after: https://cloud.skylarbarrera.com/Screen-Recording-2022-08-29-10-18-32.mp4
What to test
test the above flow.
NOTE: note you need to change the
valueindefaultConfigto get some instances of the check to work atm.Final checklist
team1/team2,critical path,release,dev QA)dev QAlabel, did you add the PR to the QA Queue?