Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix settings StatusIcon shadows on android #4104

Merged
merged 3 commits into from
Aug 31, 2022
Merged

fix settings StatusIcon shadows on android #4104

merged 3 commits into from
Aug 31, 2022

Conversation

benisgold
Copy link
Contributor

Fixes RNBW-4415
Figma link (if any):

What changed (plus any additional context for devs)

  • added elevation prop to icons to make shadows visible on android

Screen recordings / screenshots

https://www.loom.com/share/8349080853bd40fb93242e1d23bfc8a5

What to test

  • just make sure the shadows look alright!

Final checklist

  • Assigned individual reviewers?
  • Added labels? (team1/team2, critical path, release, dev QA)
  • Did you test both iOS and Android?
  • If your changes are visual, did you check both the light and dark themes?
  • Added e2e tests? If not, please specify why
  • If you added new critical path files, did you update the CODEOWNERS file?
  • If no dev QA label, did you add the PR to the QA Queue?

@benisgold benisgold added nice for release notifications team2 dev QA PR that can be safely QA'd by devs for merge (feature-specific limited impact). QA during regression labels Aug 30, 2022
@benisgold benisgold requested a review from a team August 30, 2022 23:05
@linear
Copy link

linear bot commented Aug 30, 2022

RNBW-4415 [Android Only] No shadows on Backup View

Happens on current release branch only on Android

I was spot checking Settings Redesign and noticed that on android we're not showing the shadows like we do on iOS.

Seen here:

image.png

Figma file with the shadow shown = https://www.figma.com/file/Xc4Pq3CLJNVG52z1K0URvP/notifications?node-id=647%3A4924

Steps:

  • on an Android device, backup some wallets or if you already have Google Backups then navigate to settings > Backup
  • Notice how to the right where the check mark is there's no shadow

ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the shadow now on Android 👍🏽

@estebanmino
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the @benisgold/fix-statusicon-shadows branch from e05fc30 to ff7b68e Compare August 31, 2022 17:25
@benisgold benisgold merged commit d20e3b2 into develop Aug 31, 2022
@benisgold benisgold deleted the @benisgold/fix-statusicon-shadows branch August 31, 2022 19:09
nickbytes pushed a commit that referenced this pull request Aug 31, 2022
@benisgold @nickbytes
fix settings StatusIcon shadows on android (#4104)
879b909 
* fix StatusIcon shadows on android

* fix StatusIcon shadows on android
estrattonbailey added a commit that referenced this pull request Sep 6, 2022
@estrattonbailey
Merge branch 'develop' of github.com:rainbow-me/rainbow into eric/rnb…
1971e2e 
…w-4378-clean-up-global-and-env-vars-in-app-move

* 'develop' of github.com:rainbow-me/rainbow: (40 commits)
  fix: quiet logs when linting in CI (#4070)
  analytics: add tracking for screen dimensions + fix nav events on android (#4088)
  fix native input cursor color (#4112)
  Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046)
  chore: upgrade eslint-config-rainbow (#4118)
  backup PIN  (#4012)
  Remove long press on address in switching wallets (#3990)
  Version bump iOS v.1.7.4 & Android 144 (#4117)
  Fix slow image loading (#4052)
  Add new text size scale, deprecate old sizes and Heading (#4113)
  Disable campaings in e2e and fix testID of PromoSheet (#4107)
  🏛 chore: prettier everything (#4100)
  fix settings StatusIcon shadows on android (#4104)
  fix clear async storage crash (#4105)
  fix RNBW-4416 (#4103)
  🏛 Update to React Query 4 (#4060)
  swaps: init cross chain feature flag (#4091)
  enable arbiitrum swap details test (#4092)
  remove unsafe access to networkInfo (#4096)
  network check (#4094)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

@pugson pugson pugson approved these changes

@nickbytes nickbytes Awaiting requested review from nickbytes

Assignees
No one assigned
Labels
dev QA PR that can be safely QA'd by devs for merge (feature-specific limited impact). QA during regression notifications rc-v1.7.3 team2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benisgold @estebanmino @pugson @ibrahimtaveras00