Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaps: fix native input cursor color #4112

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

skylarbarrera
Copy link
Contributor

Fixes TEAM2-489
Figma link (if any):

What changed (plus any additional context for devs)

noticed the native input cursor color was wrong, this fixes it

Screen recordings / screenshots

after: https://cloud.skylarbarrera.com/Screen-Shot-2022-08-31-15-22-28.91.png

What to test

check the native input cursor color for l2 assets

Final checklist

  • Assigned individual reviewers?
  • Added labels? (team1/team2, critical path, release, dev QA)
  • Did you test both iOS and Android?
  • If your changes are visual, did you check both the light and dark themes?
  • Added e2e tests? If not, please specify why
  • If you added new critical path files, did you update the CODEOWNERS file?
  • If no dev QA label, did you add the PR to the QA Queue?

@skylarbarrera skylarbarrera added swap-aggregator Label for the swap aggregator feature project team2 dev QA PR that can be safely QA'd by devs for merge (feature-specific limited impact). QA during regression labels Aug 31, 2022
@linear
Copy link

linear bot commented Aug 31, 2022

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skylarbarrera skylarbarrera merged commit c692167 into develop Sep 2, 2022
@skylarbarrera skylarbarrera deleted the @skylar/fix-native-input-cursor branch September 2, 2022 18:53
estrattonbailey added a commit that referenced this pull request Sep 6, 2022
…w-4378-clean-up-global-and-env-vars-in-app-move

* 'develop' of github.com:rainbow-me/rainbow: (40 commits)
  fix: quiet logs when linting in CI (#4070)
  analytics: add tracking for screen dimensions + fix nav events on android (#4088)
  fix native input cursor color (#4112)
  Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046)
  chore: upgrade eslint-config-rainbow (#4118)
  backup PIN  (#4012)
  Remove long press on address in switching wallets (#3990)
  Version bump iOS v.1.7.4 & Android 144 (#4117)
  Fix slow image loading (#4052)
  Add new text size scale, deprecate old sizes and Heading (#4113)
  Disable campaings in e2e and fix testID of PromoSheet (#4107)
  🏛 chore: prettier everything (#4100)
  fix settings StatusIcon shadows on android (#4104)
  fix clear async storage crash (#4105)
  fix RNBW-4416 (#4103)
  🏛 Update to React Query 4 (#4060)
  swaps: init cross chain feature flag (#4091)
  enable arbiitrum swap details test (#4092)
  remove unsafe access to networkInfo (#4096)
  network check (#4094)
  ...
estrattonbailey added a commit that referenced this pull request Sep 6, 2022
…w-4388-configure-jest-for-unit-tests

* 'develop' of github.com:rainbow-me/rainbow:
  Profiles: Support contenthash (#4067)
  🏛 GraphQL Clients/Codegen Foundations (#4086)
  fix: quiet logs when linting in CI (#4070)
  analytics: add tracking for screen dimensions + fix nav events on android (#4088)
  fix native input cursor color (#4112)
  Profiles: use `name` text record instead of `me.rainbow.displayName` (#4046)
  chore: upgrade eslint-config-rainbow (#4118)
  backup PIN  (#4012)
  Remove long press on address in switching wallets (#3990)
  Version bump iOS v.1.7.4 & Android 144 (#4117)
  Fix slow image loading (#4052)
  Add new text size scale, deprecate old sizes and Heading (#4113)
estebanmino pushed a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev QA PR that can be safely QA'd by devs for merge (feature-specific limited impact). QA during regression swap-aggregator Label for the swap aggregator feature project team2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants