Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keith changes 08 01 #8

Closed
wants to merge 46 commits into from
Closed

Keith changes 08 01 #8

wants to merge 46 commits into from

Conversation

reggie-k
Copy link
Owner

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

dhruvang1 and others added 30 commits December 3, 2023 17:54
@dhruvang1
fix(appset): Don't use revision cache when reconciling after webhook (a…
7408292 
…rgoproj#16062) (argoproj#16241)

* fix(appset): store sha from webhook to get latest change during reconcile (argoproj#16062)

Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com>

* fix(appset): Don't use revision cache when reconciling after webhook(argoproj#16062)

Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com>

---------

Signed-off-by: dhruvang1 <dhruvang1@users.noreply.github.com>
@speedfl
fix(doc): Fix documentation templatePatch (argoproj#16522)
30b92b2 
Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>
@chr15murray
fix: cert-manager.io/certificate health.lua for consistent issuing (I…
8886874 
…ssue argoproj#16523) (argoproj#16520)

* Update cert-manager.opcertificate health.lua

Signed-off-by: Chris Murray <chris@distrail.io>

* adding test case for cert issuing

Signed-off-by: Chris Murray <chris@distrail.io>

* fixing typo

Signed-off-by: Chris Murray <chris@distrail.io>

---------

Signed-off-by: Chris Murray <chris@distrail.io>
@ondrejsika
fix: Use math.MaxInt (instead of math.MaxInt64) to fix builds on 32bi…
99c2859 
…t platforms (argoproj#16065)

Signed-off-by: Ondrej Sika <ondrej@ondrejsika.com>
@ffppmm
Added missing 'alias:' prefix for repository name as described here: (a…
7484f1d 
…rgoproj#15902)
@jsoref @crenshaw-dev
fix(ui): use background delete to match k8s terminology (argoproj#15579)
5c51dcb 
Signed-off-by: Josh Soref <jsoref@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@elouanKeryell-Even
docs: Fix format issue in rbac.md (argoproj#16521)
07a2e64 
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break

Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>
@philnichol
docs: Fix minor typo in Declarative Setup (argoproj#16550)
86f79ec 
Signed-off-by: Phil Nichol <35630607+philnichol@users.noreply.github.com>
@jessesuen
chore: update PR template to suggest cherry-pick releases (argoproj#1…
710777e 
…6560)

Signed-off-by: Jesse Suen <jesse@akuity.io>
@rotemtam
resource_customizations/db.atlasgo.io: atlas operator resources (argo…
35f1ee7 
…proj#16364)

Signed-off-by: Rotem Tamir <rotemtamir@gmail.com>
@mikutas
fix(appset): Always remove ownerReferences when appset policy doesn't…
9179835 
… allow app's deletion (argoproj#12172) (argoproj#16506)

* fix(appset): remove unnecessary condition

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

* docs: update explanation about policy

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>

---------

Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@reversearrow
docs: Add Kong Inc. as a user (argoproj#16582)
f67dcac 
Signed-off-by: Jay Shah <jay.shah@konghq.com>
@reegnz
chore: upgrade kubernetes dependencies from 0.26.4 to 0.26.11 (argopr…
a761a49 
…oj#16581)

* chore: upgrade kubernetes dependencies from 0.26.4 to 0.26.11

Fixes some vulnerabilities trivy is reporting on (not necessarily
vulnerabe, trivy tends to have a lot of false positives when it comes to
golang projects):

* CVE-2023-3676
* CVE-2023-3955
* CVE-2023-5528
* CVE-2023-2431
* CVE-2023-2727
* CVE-2023-2728

Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>

* go mod tidy

Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>

* Add go mod tidy to kubernetes updater script

Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>

---------

Signed-off-by: Zoltán Reegn <zoltan.reegn@gmail.com>
@elouanKeryell-Even
docs: fix broken link in secret-management.md (argoproj#16588)
10bb8b0 
Signed-off-by: Elouan Keryell-Even <elouan.keryell@gmail.com>
@dmpe
docs(monitoring): add new ServiceMonitors for redis, dex, notificatio…
d70f9a4 
…ns (argoproj#16534)

Signed-off-by: dmpe <cincenko@outlook.com>
@jasonwzm
Add Statsig as a user (argoproj#16604)
cde68e0 
Signed-off-by: Jason Wang <7304774+jasonwzm@users.noreply.github.com>
@yedayak
docs: fix indentation for preserve file mode (argoproj#16598)
ecef174 
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here.

Signed-off-by: yedayak <yedaya.ka@gmail.com>
@nromriell
fix(repo-server): excess git requests, short-circuit GenerateManifest…
2ad419b 
…s ref only (argoproj#16501)

* fix(repo-server): excess git requests part 2, short-circuit GenerateManifests ref only

Signed-off-by: nromriell <nateromriell@gmail.com>

* chore(logging): pr feedback, add debug log to short circuit

Signed-off-by: nromriell <nateromriell@gmail.com>

* chore: pr feedback, add ref to debug statement

Signed-off-by: nromriell <nateromriell@gmail.com>

---------

Signed-off-by: nromriell <nateromriell@gmail.com>
@flux-ricky
fix(cli): argocd admin settings resource-overrides health to not ig…
23959ca 
…nore wildard customizations (argoproj#16461)

Signed-off-by: Ricky McMillen <ricky.mcmillen@fluxfederation.com>
@matthewhughes934
Add meta.Duration as known type for diffing (argoproj#16587)
a7d0da9 
So that this can be used for custom resources. The motivation for this
is issue argoproj#6008: with this change one should be able to use the known
type to ensure equal durations don't present a diff, e,g. via adding to
`argocd-cm`:

    data:
      resource.customizations.knownTypeFields.cert-manager.io_Certificate: |
        - field: spec.duration
          type: meta/v1/Duration

This change is based on 5b464c9, though
I've included the API version in the type path to be consistent with the
generated type (i.e. `meta/v1/Duration` and not `meta/Duration`).

For documentation I've just manually listed the extra types that aren't
auto-generated, though this requires having to keep this list and the
code in-sync but this is probably not a big issue since the number of
extra types is not frequently changed.

In the tests I've used `require.*` methods since I find this simpler
than `if !assert.Blah(...) { return }` which the other tests in this
file are using.

Signed-off-by: Matthew Hughes <matthewhughes934@gmail.com>
@afrancis101
fix(action): Add missing owner refs and annotation to create-job acti…
a6d8a01 
…on (argoproj#16607)

Signed-off-by: Arron Francis <arron.francis@mettle.co.uk>
@dennispan
docs: callout the need to restart pods to pickup service accounts (ar…
2f22a69 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
@robinlieb
docs: update telepresence quickstart link (argoproj#16616)
bdf2c6a 
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
@morremeyer
docs: add documentation for the argocd cluster commands (argoproj#16555)
0b35e2f 
* docs: add documentation for the argocd cluster commands

This adds initial non-reference documentation for the `argocd cluster` commands as part of argoproj#14531.

The main goal here is to bootstrap that page and point users wanting to remove the `in-cluster` cluster to
the right setting.

Signed-off-by: Maurice Meyer <mmeyer@anaconda.com>

* fixup! docs: add documentation for the argocd cluster commands

Signed-off-by: Morre <morre@mor.re>

* fixup! docs: add documentation for the argocd cluster commands

Signed-off-by: Maurice Meyer <mmeyer@anaconda.com>

---------

Signed-off-by: Maurice Meyer <mmeyer@anaconda.com>
Signed-off-by: Morre <morre@mor.re>
@SG60 @gdsoumya
fix(appset): Use case insensitive comparison of repo details in appse…
c5d5cdb 
…t webhook handler (argoproj#16503) (argoproj#16504)

* fix: case insensitive comparison of repo details in appset webhook handler

Signed-off-by: Sam Greening <2552620+SG60@users.noreply.github.com>

* chore(appset test): test case-insensitivity of appset github webhooks

Signed-off-by: Sam Greening <2552620+SG60@users.noreply.github.com>

* chore(appset test): test case for PR labeled event

And fix a couple of spelling errors

Signed-off-by: Sam Greening <2552620+SG60@users.noreply.github.com>

---------

Signed-off-by: Sam Greening <2552620+SG60@users.noreply.github.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
@crenshaw-dev
feat(security): log user when access is blocked (argoproj#16558)
23e0d52 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@alexmt
feat: PostDelete hook support (argoproj#16595)
dcc17f7 
* feat: PostDelete hooks support

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>


---------

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@ashutosh16 @crenshaw-dev
feat(ui): Show prompt when every resource requires pruning (argoproj#…
9abc1cc 
…16603)

* fix(ui): show prompt when using prune option

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* fix(ui): show prompt when using prune option

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* fix(ui): show prompt when using prune option

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

fix(ui): show prompt when using prune option

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

* chore: update message and simplify code

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* don't warn on partial sync

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix(ui): lint

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>

---------

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@leoluz
feat: Implement Server-Side Diff (argoproj#13663)
82ca7a7 
* feat: Implement Server-Side Diff

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* propagate the refreshtype to the diff config

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Create the serverSideDiff config

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* chore: add featureflag utility package

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* remove featureflag package

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* add param

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* make ssd configurable with app annotation

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* add server-side-diff flags

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* apply the same logic regardless of the refresh type

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* fix gitops-engine reference

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* docs: add docs related to server-side-diff

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* docs: update doc

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add config to include mutation webhooks

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* go mod update

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add sdd cache test case

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* fix ssd cache unit test

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Update clidocs

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* update manifests

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Fix procfile

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* additional doc changes

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* update gitops-engine version

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

---------

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@alexymantha
feat(ui): add status panel extensions (argoproj#15780)
87e95b7 
* add extension

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* rename to status panel

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* wip

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* cleanup

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* add docs

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* add key

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* fix copy/paste

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* wip

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* flyout

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* cleanup

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* lint

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* document flyout

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* rename

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

* linting

Signed-off-by: Alexy Mantha <alexy@mantha.dev>

---------

Signed-off-by: Alexy Mantha <alexy@mantha.dev>
dependabot bot and others added 16 commits December 19, 2023 00:25
@dependabot
chore(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (argoproj…
3224102 
…#16645)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@iam-veeramalla
chore: fix typo in application controller description (argoproj#16671)
7847e7f 
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
@robinlieb
feat: add initiated by in history and rollback view (argoproj#16654)
0e67ed8 
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
@sm0ca
Update contributors-quickstart.md to include minikube as local cluste…
7d1f6a1 
…r alternative. (argoproj#16690)

Signed-off-by: Sanchaai Mathiyarasan <sanchaai.mathi@gmail.com>
@markestiller
Update contributors-quickstart.md to include a link to Go's installat…
20f7182 
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
@strainovic
Multiple hook delete policies can be specified as a comma separated l…
f0f4a4e 
…ist (argoproj#16659)

Based on https://github.com/argoproj/gitops-engine/blob/master/pkg/sync/hook/delete_policy.go#L13 multiple hook delete policies are also allowed.

Signed-off-by: Nenad Strainovic <nenad.strainovic@asseco-see.rs>
@ATGardner
fix broken link (argoproj#16722)
80ca563 
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
@crenshaw-dev
docs: configmap items are strings (argoproj#16737)
a40330f 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@morey-tech
docs: remove core install commands from getting started (argoproj#16735)
1975074 
* docs: remove core install commands from getting started

I often accidentally run the core install commands when quickly copying and pasting commands from the getting started guide, which leads to confusion. I've also spent plenty of time helping newcomers to Argo CD who have done the same and are confused when they can't reach the UI.

Given that this is a "getting started" guide, it's ideal to provide only the commands required. I've removed the commands and left the link out to the core install page for those who are interested in going down that path.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: use link to install commands in core docs

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: use tip and improve wording

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

---------

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@jgwerner
Update USERS.md with IllumiDesk (argoproj#16742)
d595550 
Signed-off-by: Greg Werner <werner.greg@gmail.com>
@ciiay
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
1372529 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
@alexmt
feat: webhook should use 'rename' to copy app manifests of previous c…
4afddf7 
…ommit (argoproj#16754)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@crenshaw-dev
docs: add context to configmap example (argoproj#16763)
c4ac5aa 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@mfreeman451
docs: Update signed-release-assets.md (argoproj#16755)
ecbd24d 
Missing \ in example

Signed-off-by: mfreeman451 <mfreeman451@gmail.com>
@lieryan @blakepettersson
Document restarting argocd after modifying argocd-cm (argoproj#12405)
40760eb 
Signed-off-by: Lie Ryan <lie.1296@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
@keithchong
Rebase Regina's latest with latest in master
8b94d2b 
Signed-off-by: Keith Chong <kykchong@redhat.com>
@reggie-k reggie-k closed this Jan 10, 2024
@reggie-k reggie-k deleted the keith-changes-08-01 branch January 10, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.