Clarify "Getting Started" launch file change #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added note should help new users or ROS 2 Dashing users avoid issues with the "Getting Started" launch file, and also explain preference for Eloquent and later. ros-navigation/navigation2#1607 ros-navigation/navigation2#1663 ros-navigation#9 ros-navigation#36
SteveMacenski
requested changes
Jul 6, 2020
|
|
||
| .. note:: | ||
|
|
||
| For ``ROS 2 Dashing Diademata`` or earlier, use |
There was a problem hiding this comment.
I think just For ROS2 Dashing or earlier, use . However, it is recommended to use the most recent LTS distribution for improved stability and feature completenes."
I don't want to name specific distributions I'll have to keep updating over time.
|
pinging @GuanyangLuo please make that simple change and we can merge |
|
Okay, I will work on it this weekend. |
Updated based on comments from the pull request. ros-navigation#37
SteveMacenski
approved these changes
Aug 3, 2020
|
Awesome! Thank you |
|
Shouldn't this be for Eloquent or earlier? Current eloquent branch has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added note should help new users or ROS 2 Dashing users avoid issues with
the "Getting Started" launch file, and also explain preference for Eloquent
and later.
ros-navigation/navigation2#1607
ros-navigation/navigation2#1663
#9
#36