Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation error: missing tb3_simulation_launch.py in Dashing #1607

Closed
facontidavide opened this issue Mar 21, 2020 · 1 comment · Fixed by #1610
Closed

Documentation error: missing tb3_simulation_launch.py in Dashing #1607

facontidavide opened this issue Mar 21, 2020 · 1 comment · Fixed by #1610

Comments

@facontidavide
Copy link
Contributor

I am not sure if this is the right place to report this, but I am not able to follow the steps described here with Dashing installed:

https://ros-planning.github.io/navigation2/getting_started/index.html

Apparently, the release of Dashing of nav2_bringup does not contain the file tb3_simulation_launch.py.

https://github.com/ros-planning/navigation2/tree/dashing-devel/nav2_bringup
@SteveMacenski
Copy link
Member

SteveMacenski commented Mar 23, 2020 •
edited
Loading

The dashing eq is nav2_simulation_launch.py

I’ll update the docs to reflect that this is from eloquent and newer, thanks for the report. I think we need to overall make the docs consistent with Foxy with that release pending.

We generally do not advise using dashing for a multitude of reasons. Eloquent is preferred and new development is on Foxy

@SteveMacenski SteveMacenski linked a pull request Mar 25, 2020 that will close this issue
making documentation distro agnostic #1610
Merged
GuanyangLuo added a commit to GuanyangLuo/navigation.ros.org that referenced this issue Jul 4, 2020
@GuanyangLuo
Clarify "Getting Started" launch file change
c386d68 
The added note should help new users or ROS 2 Dashing users avoid issues with
the "Getting Started" launch file, and also explain preference for Eloquent
and later.

ros-navigation/navigation2#1607
ros-navigation/navigation2#1663
ros-navigation#9
ros-navigation#36
@GuanyangLuo GuanyangLuo mentioned this issue Jul 4, 2020
Merged
SteveMacenski pushed a commit to ros-navigation/docs.nav2.org that referenced this issue Aug 3, 2020
@GuanyangLuo
Clarify "Getting Started" launch file change (#37)
341f2ae 
* Clarify "Getting Started" launch file change

The added note should help new users or ROS 2 Dashing users avoid issues with
the "Getting Started" launch file, and also explain preference for Eloquent
and later.

ros-navigation/navigation2#1607
ros-navigation/navigation2#1663
#9
#36

* Avoid recommending a specific ROS 2 distro

Updated based on comments from the pull request.

#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

making documentation distro agnostic SteveMacenski/navigation2
2 participants
@facontidavide @SteveMacenski