Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1663

Closed
adamkrawczyk opened this issue Apr 29, 2020 · 8 comments
Closed

Update docs #1663

adamkrawczyk opened this issue Apr 29, 2020 · 8 comments
Assignees

Comments

@adamkrawczyk
Copy link

Bug report

Required Info:

  • Operating System:
    • ubuntu 18
  • Version or commit hash:
    • website
  • DDS implementation:
    • cyclone dds

Steps to reproduce the issue

Just follow steps at the website to launch demo navigation with turtlebot3

https://ros-planning.github.io/navigation2/getting_started/index.html

Expected behavior

Turtlebot driving autonomously

Actual behavior

No launch file. Launch file provided with the package doesn't work.

Additional information

After launching simulation ros2 launch nav2_bringup nav2_simulation_launch.py there is no map.

@shivaang12 shivaang12 self-assigned this Apr 29, 2020
@shivaang12
Copy link
Collaborator

shivaang12 commented Apr 29, 2020

Hi @adamkrawczyk I was wondering where are you looking for maps? In Nav2's repo or Turtlebot's repo?

I think you have to provide map through cli argument like for example

ros2 launch nav2_bringup nav2_simulation_launch.py map:=path/to/map

I suggest you to look (here)[https://github.com/ros-planning/navigation2/blob/master/nav2_bringup/bringup/README.md] for how to pass params.

And for the map, you can find prebuild map in nav2_bringup package under map directory.

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 29, 2020

Nav2 simulation launch is circa dashing. Where did you find instructions to use that?

The directions should tell you to use tb3_simulation.py.launch for Eloquent and newer.

@shivaang12 not sure what you mean by maps wrt launch files not running

@adamkrawczyk
Copy link
Author

adamkrawczyk commented Apr 29, 2020

I'm just saying that the provided command doesn't work. Rest of the demo works fine.

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 29, 2020

Where did you find that command, specifically?

I’m looking at the website and I can’t find a reference to that launch file.

@adamkrawczyk
Copy link
Author

adamkrawczyk commented Apr 29, 2020

https://ros-planning.github.io/navigation2/getting_started/index.html

Here is the command. Also I've checked source now and got that command is correct but the binary version for dashing doesn't come with specified launch file.

So this should be more like 'update binary version for dashing'

I have only

/opt/ros/dashing/share/nav2_bringup/launch$ ls

bt_navigator.xml        nav2_localization_launch.py  turtlebot3_world.pgm
gazebo_rviz2_launch.py  nav2_navigation_launch.py    turtlebot3_world.yaml
nav2_bringup_launch.py  nav2_params.yaml
nav2_default_view.rviz  nav2_simulation_launch.py

@shivaang12
Copy link
Collaborator

@adamkrawczyk Sorry, I think I miss understood you before. tb3_simulation_launch.py was introduced later after Dashing release.

@SteveMacenski Can we cherrypick this thing? or not?

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 29, 2020

That page is for Eloquent and newer, we changed that launch file right after the dashing release to better describe its function. Sorry if that caused you trouble; we've been recommending users to use Eloquent or ROS2 master since Dashing is a little buggy and it was massively improved in Eloquent.

I'd welcome a PR from you though at https://github.com/ros-planning/navigation.ros.org to add a "Note:" about if using dashing or older, use the nav2_simulation_launch.py file. You're now the second new user to mention that issue and we should address it. You can find the source for that specific page here.

@adamkrawczyk
Copy link
Author

Okay, thank you. I’m closing now

GuanyangLuo added a commit to GuanyangLuo/navigation.ros.org that referenced this issue Jul 4, 2020
The added note should help new users or ROS 2 Dashing users avoid issues with
the "Getting Started" launch file, and also explain preference for Eloquent
and later.

ros-navigation/navigation2#1607
ros-navigation/navigation2#1663
ros-navigation#9
ros-navigation#36
SteveMacenski pushed a commit to ros-navigation/docs.nav2.org that referenced this issue Aug 3, 2020
* Clarify "Getting Started" launch file change

The added note should help new users or ROS 2 Dashing users avoid issues with
the "Getting Started" launch file, and also explain preference for Eloquent
and later.

ros-navigation/navigation2#1607
ros-navigation/navigation2#1663
#9
#36

* Avoid recommending a specific ROS 2 distro

Updated based on comments from the pull request.

#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants