-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift clippy::double_neg
lint as double_negations
#126604
base: master
Are you sure you want to change the base?
Conversation
r? @nnethercote rustbot has assigned @nnethercote. Use |
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
af85271
to
a745a8d
Compare
@rustbot author |
This needs T-lang approval. The appropriate labels have been applied to summon them. |
☔ The latest upstream changes (presumably #127174) made this pull request unmergeable. Please resolve the merge conflicts. |
a745a8d
to
8f3387c
Compare
clippy::double_neg
lint as double_negation
clippy::double_neg
lint as double_negations
This comment has been minimized.
This comment has been minimized.
8f3387c
to
9862f05
Compare
@rustbot ready |
Still waiting on T-lang, AFAICT. |
@rustbot label: -S-waiting-on-review +S-waiting-on-team |
☔ The latest upstream changes (presumably #128985) made this pull request unmergeable. Please resolve the merge conflicts. |
9862f05
to
beb1dd2
Compare
This comment has been minimized.
This comment has been minimized.
beb1dd2
to
608040d
Compare
☔ The latest upstream changes (presumably #132746) made this pull request unmergeable. Please resolve the merge conflicts. |
608040d
to
5b59711
Compare
Warns about cases like this:
The intent is to keep people from thinking that
--x
is a prefix decrement operator.++x
,x++
andx--
are invalid expressions and already have a helpful diagnostic.I didn't add a machine-applicable suggestion to the lint because it's not entirely clear what the programmer was trying to achieve with the
--x
operation. The code that triggers the lint should always be reviewed manually.Closes #82987