-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fully de-stabilize all custom inner attributes #134276
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
ca4ddc2
to
cb2a31c
Compare
@bors try |
…tr, r=<try> fully de-stabilize all custom inner attributes `#![test]` and `#![rustfmt::skip]` were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (rust-lang#82399) and shown in future-compat reports since Rust 1.77 (rust-lang#116274). Cc `@rust-lang/lang` `@petrochenkov`
☀️ Try build successful - checks-actions |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚨 Report generation of 🆘 Can someone from the infra team check in on this? @rust-lang/infra |
@craterbot retry-report |
🛠️ Generation of the report for ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was going to write an in-depth analysis of the crater results, and then nominate this for the lang team. |
I'm ok with the change itself. Nominate the lang team is certainly better, and I think it's necessary. |
I went over the crates.io regressions in detail, see https://hackmd.io/@RalfJung/H1PIEyNr1e. They are all spurious except for 2, which are both in crates that only ever had 1 version published 4 years ago and that have <2k downloads in total. So I think we can move ahead here, these attributes are basically unused. |
@rfcbot reviewed |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
@rustbot labels -S-waiting-on-fcp With FCP complete, this is good to go forward as far as lang is concerned. |
cb2a31c
to
5bd20b0
Compare
@bors r=@SparrowLii |
Rollup of 5 pull requests Successful merges: - rust-lang#134276 (fully de-stabilize all custom inner attributes) - rust-lang#135237 (Match Ergonomics 2024: document and reorganize the currently-implemented feature gates) - rust-lang#135310 (Always force non-trimming of path in `unreachable_patterns` lint) - rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages) - rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134276 - RalfJung:destabilize-custom-inner-attr, r=SparrowLii fully de-stabilize all custom inner attributes `#![test]` and `#![rustfmt::skip]` were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (rust-lang#82399) and shown in future-compat reports since Rust 1.77 (rust-lang#116274). Cc `@rust-lang/lang` `@petrochenkov`
#![test]
and#![rustfmt::skip]
were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (#82399) and shown in future-compat reports since Rust 1.77 (#116274).Cc @rust-lang/lang @petrochenkov