Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully de-stabilize all custom inner attributes #134276

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

RalfJung
Copy link
Member

#![test] and #![rustfmt::skip] were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (#82399) and shown in future-compat reports since Rust 1.77 (#116274).

Cc @rust-lang/lang @petrochenkov

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2024
@RalfJung RalfJung force-pushed the destabilize-custom-inner-attr branch from ca4ddc2 to cb2a31c Compare December 13, 2024 17:50
@RalfJung RalfJung added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Dec 13, 2024
@RalfJung
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
…tr, r=<try>

fully de-stabilize all custom inner attributes

`#![test]` and `#![rustfmt::skip]` were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (rust-lang#82399) and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

Cc `@rust-lang/lang` `@petrochenkov`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit cb2a31c with merge da0275e...

@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: da0275e (da0275e101cdc809ce291ed8b64d6f82c6b65467)

@RalfJung
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-134276 created and queued.
🤖 Automatically detected try build da0275e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2024
@RalfJung RalfJung added I-lang-nominated Nominated for discussion during a lang team meeting. and removed I-lang-nominated Nominated for discussion during a lang team meeting. labels Dec 14, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-134276 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Report generation of pr-134276 failed: timed out waiting for connection
🛠️ If the error is fixed use the retry-report command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@RalfJung
Copy link
Member Author

@craterbot retry-report

@craterbot
Copy link
Collaborator

🛠️ Generation of the report for pr-134276 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-134276 is completed!
📊 167 regressed and 32 fixed (553892 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 17, 2024
Copy link
Member

@SparrowLii SparrowLii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RalfJung
Copy link
Member Author

I was going to write an in-depth analysis of the crater results, and then nominate this for the lang team.

@SparrowLii
Copy link
Member

I'm ok with the change itself. Nominate the lang team is certainly better, and I think it's necessary.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2024
@RalfJung
Copy link
Member Author

I went over the crates.io regressions in detail, see https://hackmd.io/@RalfJung/H1PIEyNr1e.

They are all spurious except for 2, which are both in crates that only ever had 1 version published 4 years ago and that have <2k downloads in total. So I think we can move ahead here, these attributes are basically unused.

@rfcbot rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Jan 8, 2025
@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

2 similar comments
@traviscross
Copy link
Contributor

@rfcbot reviewed

@scottmcm
Copy link
Member

scottmcm commented Jan 8, 2025

@rfcbot reviewed

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 8, 2025
@rfcbot
Copy link

rfcbot commented Jan 8, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 8, 2025
@traviscross traviscross removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Jan 8, 2025
@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 14, 2025
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 18, 2025
@rfcbot
Copy link

rfcbot commented Jan 18, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@traviscross
Copy link
Contributor

@rustbot labels -S-waiting-on-fcp

With FCP complete, this is good to go forward as far as lang is concerned.

@rustbot rustbot removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Jan 19, 2025
@RalfJung RalfJung force-pushed the destabilize-custom-inner-attr branch from cb2a31c to 5bd20b0 Compare January 19, 2025 15:53
@RalfJung
Copy link
Member Author

@bors r=@SparrowLii
(based on this)

@bors
Copy link
Contributor

bors commented Jan 19, 2025

📌 Commit 5bd20b0 has been approved by SparrowLii

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 19, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134276 (fully de-stabilize all custom inner attributes)
 - rust-lang#135237 (Match Ergonomics 2024: document and reorganize the currently-implemented feature gates)
 - rust-lang#135310 (Always force non-trimming of path in `unreachable_patterns` lint)
 - rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages)
 - rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit be8f1f9 into rust-lang:master Jan 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2025
Rollup merge of rust-lang#134276 - RalfJung:destabilize-custom-inner-attr, r=SparrowLii

fully de-stabilize all custom inner attributes

`#![test]` and `#![rustfmt::skip]` were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (rust-lang#82399) and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

Cc `@rust-lang/lang` `@petrochenkov`
@RalfJung RalfJung deleted the destabilize-custom-inner-attr branch January 20, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.