Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace i686-unknown-redox target with i586-unknown-redox #136698

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Replace i686-unknown-redox target with i586-unknown-redox #136698

merged 3 commits into from
Feb 12, 2025

Conversation

jackpot51
Copy link
Contributor

This change is related to #136495

@rustbot

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@jackpot51 jackpot51 mentioned this pull request Feb 7, 2025
Open
5 tasks
@jieyouxu
Copy link
Member

jieyouxu commented Feb 7, 2025

cc @RalfJung
r? compiler

@rustbot rustbot assigned oli-obk and unassigned GuillaumeGomez Feb 7, 2025
@jieyouxu jieyouxu added the O-redox Operating system: Redox, https://www.redox-os.org/ label Feb 7, 2025
@RalfJung
Copy link
Member

RalfJung commented Feb 7, 2025

Thanks! That would resolve the naming concern.

Should we make any arrangements for a transition period, like keep the old target around for a bit? (Not sure if we have a way to mark a target as "deprecated".)

@jieyouxu
Copy link
Member

jieyouxu commented Feb 7, 2025 •
edited
Loading

Should we make any arrangements for a transition period, like keep the old target around for a bit? (Not sure if we have a way to mark a target as "deprecated".)

No dedicated infrastructure (yet). The closest approach I know of is the wasm32-wasip1 naming transition rust-lang/compiler-team#695, but that required careful manual transition implementation (ship alias, warning, blog posts, etc.).

@Noratrieb
Copy link
Member

One reason to keep the old target for a bit would be so that people can use the same config for stable and nightly, but given that this is tier 3 I expect everyone to use nightly anyways so just doing it directly seems fine.
@jackpot51 you can decide if you want to keep the old target around a bit or just have the old one.

I wouldn't bother with any warnings for this.

@jackpot51
Copy link
Contributor Author

There's no fundamental reason to keep the old target around. Redox OS upstream builds use a pinned nightly version, so we simply won't update it until the necessary changes here have been adapted to.

@Noratrieb Noratrieb added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 7, 2025
@rustbot rustbot mentioned this pull request Feb 7, 2025
Open
3 tasks
@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@jackpot51 jackpot51 requested a review from RalfJung February 11, 2025 17:22
@RalfJung
Copy link
Member

LGTM, and you are target maintainer so we have that approval as well. Thanks for preparing the PR!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2025

📌 Commit 54c15eb has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 12, 2025
@GuillaumeGomez
Rollup merge of rust-lang#136698 - jackpot51:i586-redox, r=RalfJung
29b825e 
Replace i686-unknown-redox target with i586-unknown-redox

This change is related to rust-lang#136495
This was referenced Feb 12, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2025
@bors
Auto merge of rust-lang#136918 - GuillaumeGomez:rollup-f6h21gg, r=Gui…
552a959 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134981 ( Explain that in paths generics can't be set on both the enum and the variant)
 - rust-lang#136698 (Replace i686-unknown-redox target with i586-unknown-redox)
 - rust-lang#136767 (improve host/cross target checking)
 - rust-lang#136829 ([rustdoc] Move line numbers into the `<code>` directly)
 - rust-lang#136875 (Rustc dev guide subtree update)
 - rust-lang#136900 (compiler: replace `ExternAbi::name` calls with formatters)
 - rust-lang#136913 (Put kobzol back on review rotation)
 - rust-lang#136915 (documentation fix: `f16` and `f128` are not double-precision)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c43a59f into rust-lang:master Feb 12, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 12, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2025
@rust-timer
Unrolled build for rust-lang#136698
fe16de2 
Rollup merge of rust-lang#136698 - jackpot51:i586-redox, r=RalfJung

Replace i686-unknown-redox target with i586-unknown-redox

This change is related to rust-lang#136495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briansmith briansmith briansmith left review comments

@bjorn3 bjorn3 bjorn3 left review comments

@workingjubilee workingjubilee workingjubilee left review comments

@RalfJung RalfJung Awaiting requested review from RalfJung

Assignees

@oli-obk oli-obk

Labels
O-redox Operating system: Redox, https://www.redox-os.org/ relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.