Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make missing_abi lint warn-by-default. #132397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make missing_abi lint warn-by-default. #132397

wants to merge 2 commits into from
+198 −143

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Oct 31, 2024 •
edited
Loading

This makes the missing_abi lint warn-by-default, as suggested here: rust-lang/rfcs#3722 (comment)

This needs a lang FCP.

@m-ou-se m-ou-se added T-lang Relevant to the language team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Oct 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2024
@m-ou-se
Copy link
Member Author

m-ou-se commented Oct 31, 2024

r? @traviscross for lang FCP

@rustbot rustbot assigned traviscross and unassigned petrochenkov Oct 31, 2024
@m-ou-se m-ou-se mentioned this pull request Oct 31, 2024
Merged
@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@y21 y21 mentioned this pull request Oct 31, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@traviscross
Copy link
Contributor

@rustbot labels +I-lang-nominated

This PR is an outcome of the discussion we started for:

Let's nominate to discuss.

@rustbot rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label Oct 31, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 8, 2024

☔ The latest upstream changes (presumably #132746) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 8, 2024
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Nov 20, 2024 •
edited
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@pthariensflame
Copy link
Contributor

Is this likely to be actually merged any time soon? It's been over a month.

@m-ou-se m-ou-se added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Jan 7, 2025
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 7, 2025

r? compiler

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 7, 2025
@rustbot rustbot assigned Nadrieril and unassigned traviscross Jan 7, 2025
@Nadrieril Nadrieril added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 8, 2025
@Nadrieril
Copy link
Member

Adding relnotes because imo it's the kind of churn users should be warned about. Thanks for the ping @pthariensflame.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2025

📌 Commit 585c976 has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2025
@bors
Auto merge of rust-lang#132397 - m-ou-se:warn-missing-abi, r=Nadrieril
c8c16f8 
Make missing_abi lint warn-by-default.

This makes the missing_abi lint warn-by-default, as suggested here: rust-lang/rfcs#3722 (comment)

This needs a lang FCP.
@bors
Copy link
Contributor

bors commented Jan 8, 2025

⌛ Testing commit 585c976 with merge c8c16f8...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 8, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2025
@m-ou-se m-ou-se mentioned this pull request Jan 8, 2025
Merged
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 8, 2025

I can't fix that error in this PR, because it is part of the cargo submodule. This PR is now blocked on rust-lang/cargo#15034 being merged and updated into the rust repository.

@m-ou-se m-ou-se added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Jan 8, 2025
@epage
Make "C" explicit in extern "C". (#15034)
d9f65ec 
We're making the `missing_abi` lint a warning in rustc, see:
rust-lang/rust#132397
@m-ou-se m-ou-se removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Jan 9, 2025
@traviscross traviscross mentioned this pull request Jan 10, 2025
Open
8 tasks
@traviscross traviscross added the L-missing_abi Lint: missing_abi label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nadrieril Nadrieril

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. L-missing_abi Lint: missing_abi relnotes Marks issues that should be documented in the release notes of the next release. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.