disallow `repr()` on invalid items #133925

folkertdev · 2024-12-05T15:48:31Z

Disallows repr() (so a repr with no arguments) on items where that won't ever make sense.

Also this generates an error when repr is used on a trait method and the fn_align feature is not enabled. Looks like that was missed here:

https://github.com/rust-lang/rust/pull/110313/files

Which first accepts the align attribute on trait methods.

r? @compiler-errors

cc @jdonszelmann who claimed #132391 and generally has been working on attributes

Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first enables the align attribute on trait methods.

compiler-errors · 2024-12-05T16:06:08Z

@bors try

compiler-errors · 2024-12-05T16:06:35Z

Nominating as a courtesy for T-lang, should be a trivial decision since this was likely never intended

…<try> disallow `repr()` on invalid items fixes rust-lang#129606 Disallows `repr()` (so a repr with no arguments) on items where that won't ever make sense. Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first accepts the align attribute on trait methods. r? `@compiler-errors`

bors · 2024-12-05T16:07:21Z

⌛ Trying commit dfd76c1 with merge 617b810...

jdonszelmann · 2024-12-05T17:04:11Z

Oh nice! If this fixes an issue you have right now, great! Especially the tests are nice so I can't mess it up again, but the code in check_attrs.rs will likely be deleted within a month. (sorry)

folkertdev · 2024-12-05T17:08:12Z

well this change unintentionally turns out to fix that ICE. And yeah the test coverage is the most important part, I'm not at all attached to this code. Good luck with your rebase!

jdonszelmann · 2024-12-05T17:09:05Z

lol thanks, can't be much worse than the current one (I'm 4 days in)

compiler-errors · 2024-12-10T22:19:39Z

r=me when T-lang comes back w/ a decision

@rustbot team

traviscross · 2025-01-08T16:11:12Z

@rfcbot fcp merge

rfcbot · 2025-01-08T16:12:02Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

tmandry · 2025-01-08T16:12:34Z

@rfcbot reviewed

rfcbot · 2025-01-08T16:12:53Z

🔔 This is now entering its final comment period, as per the review above. 🔔

nikomatsakis · 2025-01-08T16:15:01Z

@rfcbot reviewed

compiler-errors · 2025-01-18T16:22:11Z

Oh, it's because the try build was canceled because you pushed another commit.

@bors try

bors · 2025-01-18T16:23:26Z

⌛ Trying commit a4bb0d4 with merge a75eafc...

…<try> disallow `repr()` on invalid items fixes rust-lang#129606 fixes rust-lang#132391 Disallows `repr()` (so a repr with no arguments) on items where that won't ever make sense. Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first accepts the align attribute on trait methods. r? `@compiler-errors` cc `@jdonszelmann` who claimed rust-lang#132391 and generally has been working on attributes

bors · 2025-01-18T18:11:30Z

☀️ Try build successful - checks-actions
Build commit: a75eafc (a75eafceea413a1b40c0e0769db85e08ec17160b)

folkertdev · 2025-01-21T21:43:52Z

@compiler-errors did you still want to run crater here?

compiler-errors · 2025-01-21T21:44:44Z

yes let's do that

@craterbot check

craterbot · 2025-01-21T21:44:57Z

👌 Experiment pr-133925 created and queued.
🤖 Automatically detected try build a75eafc
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-01-23T03:02:21Z

🚧 Experiment pr-133925 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-01-24T01:07:31Z

🎉 Experiment pr-133925 is completed!
📊 6 regressed and 3 fixed (571795 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

folkertdev · 2025-01-28T21:00:33Z

I don't think the crater run showed any serious issues? Or in any case nothing related to this change as far as I can see.

compiler-errors · 2025-02-06T17:54:20Z

Crater looks fine.

@bors r+ rollup

bors · 2025-02-06T17:54:23Z

📌 Commit a4bb0d4 has been approved by compiler-errors

It is now in the queue for this repository.

…r=compiler-errors disallow `repr()` on invalid items fixes rust-lang#129606 fixes rust-lang#132391 Disallows `repr()` (so a repr with no arguments) on items where that won't ever make sense. Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first accepts the align attribute on trait methods. r? `@compiler-errors` cc `@jdonszelmann` who claimed rust-lang#132391 and generally has been working on attributes

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133925 (disallow `repr()` on invalid items) - rust-lang#135549 (Document some safety constraints and use more safe wrappers) - rust-lang#136069 (Simplify slice indexing in next trait solver) - rust-lang#136152 (Stabilize `map_many_mut` feature) - rust-lang#136219 (Misc. `rustc_hir` cleanups 🧹) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136636 (Couple of minor cleanups to the diagnostic infrastructure) - rust-lang#136645 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133925 (disallow `repr()` on invalid items) - rust-lang#136069 (Simplify slice indexing in next trait solver) - rust-lang#136152 (Stabilize `map_many_mut` feature) - rust-lang#136219 (Misc. `rustc_hir` cleanups 🧹) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136636 (Couple of minor cleanups to the diagnostic infrastructure) - rust-lang#136645 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#133925 - folkertdev:improve-repr-warnings, r=compiler-errors disallow `repr()` on invalid items fixes rust-lang#129606 fixes rust-lang#132391 Disallows `repr()` (so a repr with no arguments) on items where that won't ever make sense. Also this generates an error when `repr` is used on a trait method and the `fn_align` feature is not enabled. Looks like that was missed here: https://github.com/rust-lang/rust/pull/110313/files Which first accepts the align attribute on trait methods. r? `@compiler-errors` cc `@jdonszelmann` who claimed rust-lang#132391 and generally has been working on attributes

Upstream changes relative to 1.85.1: Version 1.86.0 (2025-04-03) ========================== Language -------- - [Stabilize upcasting trait objects to supertraits.] (rust-lang/rust#134367) - [Allow safe functions to be marked with the `#[target_feature]` attribute.] (rust-lang/rust#134090) - [The `missing_abi` lint now warns-by-default.] (rust-lang/rust#132397) - Rust now lints about double negations, to catch cases that might have intended to be a prefix decrement operator (`--x`) as written in other languages. This was previously a clippy lint, `clippy::double_neg`, and is [now available directly in Rust as `double_negations`.] (rust-lang/rust#126604) - [More pointers are now detected as definitely not-null based on their alignment in const eval.] (rust-lang/rust#133700) - [Empty `repr()` attribute applied to invalid items are now correctly rejected.] (rust-lang/rust#133925) - [Inner attributes `#![test]` and `#![rustfmt::skip]` are no longer accepted in more places than intended.] (rust-lang/rust#134276) Compiler -------- - [Debug-assert that raw pointers are non-null on access.] (rust-lang/rust#134424) - [Change `-O` to mean `-C opt-level=3` instead of `-C opt-level=2` to match Cargo's defaults.] (rust-lang/rust#135439) - [Fix emission of `overflowing_literals` under certain macro environments.] (rust-lang/rust#136393) Platform Support ---------------- - [Replace `i686-unknown-redox` target with `i586-unknown-redox`.] (rust-lang/rust#136698) - [Increase baseline CPU of `i686-unknown-hurd-gnu` to Pentium 4.] (rust-lang/rust#136700) - New tier 3 targets: - [`{aarch64-unknown,x86_64-pc}-nto-qnx710_iosock`] (rust-lang/rust#133631). For supporting Neutrino QNX 7.1 with `io-socket` network stack. - [`{aarch64-unknown,x86_64-pc}-nto-qnx800`] (rust-lang/rust#133631). For supporting Neutrino QNX 8.0 (`no_std`-only). - [`{x86_64,i686}-win7-windows-gnu`] (rust-lang/rust#134609). Intended for backwards compatibility with Windows 7. `{x86_64,i686}-win7-windows-msvc` are the Windows MSVC counterparts that already exist as Tier 3 targets. - [`amdgcn-amd-amdhsa`](rust-lang/rust#134740). - [`x86_64-pc-cygwin`](rust-lang/rust#134999). - [`{mips,mipsel}-mti-none-elf`] (rust-lang/rust#135074). Initial bare-metal support. - [`m68k-unknown-none-elf`](rust-lang/rust#135085). - [`armv7a-nuttx-{eabi,eabihf}`, `aarch64-unknown-nuttx`, and `thumbv7a-nuttx-{eabi,eabihf}`] (rust-lang/rust#135757). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - The type of `FromBytesWithNulError` in `CStr::from_bytes_with_nul(bytes: &[u8]) -> Result<&Self, FromBytesWithNulError>` was [changed from an opaque struct to an enum] (rust-lang/rust#134143), allowing users to examine why the conversion failed. - [Remove `RustcDecodable` and `RustcEncodable`.] (rust-lang/rust#134272) - [Deprecate libtest's `--logfile` option.] (rust-lang/rust#134283) - [On recent versions of Windows, `std::fs::remove_file` will now remove read-only files.] (rust-lang/rust#134679) Stabilized APIs --------------- - [`{float}::next_down`] (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.next_down) - [`{float}::next_up`] (https://doc.rust-lang.org/stable/std/primitive.f64.html#method.next_up) - [`<[_]>::get_disjoint_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.get_disjoint_mut) - [`<[_]>::get_disjoint_unchecked_mut`] (https://doc.rust-lang.org/stable/std/primitive.slice.html#method.get_disjoint_unchecked_mut) - [`slice::GetDisjointMutError`] (https://doc.rust-lang.org/stable/std/slice/enum.GetDisjointMutError.html) - [`HashMap::get_disjoint_mut`] (https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.get_disjoint_mut) - [`HashMap::get_disjoint_unchecked_mut`] (https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.get_disjoint_unchecked_mut) - [`NonZero::count_ones`] (https://doc.rust-lang.org/stable/std/num/struct.NonZero.html#method.count_ones) - [`Vec::pop_if`] (https://doc.rust-lang.org/std/vec/struct.Vec.html#method.pop_if) - [`sync::Once::wait`] (https://doc.rust-lang.org/stable/std/sync/struct.Once.html#method.wait) - [`sync::Once::wait_force`] (https://doc.rust-lang.org/stable/std/sync/struct.Once.html#method.wait_force) - [`sync::OnceLock::wait`] (https://doc.rust-lang.org/stable/std/sync/struct.OnceLock.html#method.wait) These APIs are now stable in const contexts: - [`hint::black_box`] (https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`io::Cursor::get_mut`] (https://doc.rust-lang.org/stable/std/io/struct.Cursor.html#method.get_mut) - [`io::Cursor::set_position`] (https://doc.rust-lang.org/stable/std/io/struct.Cursor.html#method.set_position) - [`str::is_char_boundary`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.is_char_boundary) - [`str::split_at`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_at) - [`str::split_at_checked`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_at_checked) - [`str::split_at_mut`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_at_mut) - [`str::split_at_mut_checked`] (https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_at_mut_checked) Cargo ----- - [When merging, replace rather than combine configuration keys that refer to a program path and its arguments.] (rust-lang/cargo#15066) - [Error if both `--package` and `--workspace` are passed but the requested package is missing.] (rust-lang/cargo#15071) This was previously silently ignored, which was considered a bug since missing packages should be reported. - [Deprecate the token argument in `cargo login` to avoid shell history leaks.] (rust-lang/cargo#15057) - [Simplify the implementation of `SourceID` comparisons.] (rust-lang/cargo#14980) This may potentially change behavior if the canonicalized URL compares differently in alternative registries. Rustdoc ----- - [Add a sans-serif font setting.] (rust-lang/rust#133636) Compatibility Notes ------------------- - [The `wasm_c_abi` future compatibility warning is now a hard error.] (rust-lang/rust#133951) Users of `wasm-bindgen` should upgrade to at least version 0.2.89, otherwise compilation will fail. - [Remove long-deprecated no-op attributes `#![no_start]` and `#![crate_id]`.] (rust-lang/rust#134300) - [The future incompatibility lint `cenum_impl_drop_cast` has been made into a hard error.] (rust-lang/rust#135964) This means it is now an error to cast a field-less enum to an integer if the enum implements `Drop`. - [SSE2 is now required for "i686" 32-bit x86 hard-float targets; disabling it causes a warning that will become a hard error eventually.] (rust-lang/rust#137037) To compile for pre-SSE2 32-bit x86, use a "i586" target instead. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Build the rustc on AArch64 Linux with ThinLTO + PGO.] (rust-lang/rust#133807) The ARM 64-bit compiler (AArch64) on Linux is now optimized with ThinLTO and PGO, similar to the optimizations we have already performed for the x86-64 compiler on Linux. This should make it up to 30% faster.

rustbot assigned compiler-errors Dec 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024

compiler-errors added the I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination label Dec 5, 2024

This comment has been minimized.

Sign in to view

fix issue 132391

a4bb0d4

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 8, 2025

traviscross removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Jan 8, 2025

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 8, 2025

traviscross removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Jan 19, 2025

craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 21, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2025

matthiaskrgr mentioned this pull request Feb 6, 2025

Rollup of 8 pull requests #136654

Closed

matthiaskrgr mentioned this pull request Feb 6, 2025

Rollup of 7 pull requests #136658

Merged

bors merged commit 4b7e55a into rust-lang:master Feb 7, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 7, 2025

chenyukang mentioned this pull request Feb 9, 2025

ICE: malformed malformed repr(align(N)) #132391

Closed

cuviper mentioned this pull request Mar 21, 2025

Draft release notes for 1.86.0 #138795

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disallow `repr()` on invalid items #133925

disallow `repr()` on invalid items #133925

folkertdev commented Dec 5, 2024 •

edited

Loading

compiler-errors commented Dec 5, 2024

compiler-errors commented Dec 5, 2024

bors commented Dec 5, 2024

This comment has been minimized.

jdonszelmann commented Dec 5, 2024

folkertdev commented Dec 5, 2024

jdonszelmann commented Dec 5, 2024 •

edited

Loading

compiler-errors commented Dec 10, 2024

traviscross commented Jan 8, 2025

rfcbot commented Jan 8, 2025 •

edited

Loading

tmandry commented Jan 8, 2025

rfcbot commented Jan 8, 2025

nikomatsakis commented Jan 8, 2025

compiler-errors commented Jan 18, 2025

bors commented Jan 18, 2025

bors commented Jan 18, 2025

folkertdev commented Jan 21, 2025

compiler-errors commented Jan 21, 2025

craterbot commented Jan 21, 2025

craterbot commented Jan 23, 2025

craterbot commented Jan 24, 2025

folkertdev commented Jan 28, 2025

compiler-errors commented Feb 6, 2025

bors commented Feb 6, 2025

disallow repr() on invalid items #133925

disallow repr() on invalid items #133925

Conversation

folkertdev commented Dec 5, 2024 • edited Loading

compiler-errors commented Dec 5, 2024

compiler-errors commented Dec 5, 2024

bors commented Dec 5, 2024

This comment has been minimized.

jdonszelmann commented Dec 5, 2024

folkertdev commented Dec 5, 2024

jdonszelmann commented Dec 5, 2024 • edited Loading

compiler-errors commented Dec 10, 2024

traviscross commented Jan 8, 2025

rfcbot commented Jan 8, 2025 • edited Loading

tmandry commented Jan 8, 2025

rfcbot commented Jan 8, 2025

nikomatsakis commented Jan 8, 2025

compiler-errors commented Jan 18, 2025

bors commented Jan 18, 2025

bors commented Jan 18, 2025

folkertdev commented Jan 21, 2025

compiler-errors commented Jan 21, 2025

craterbot commented Jan 21, 2025

craterbot commented Jan 23, 2025

craterbot commented Jan 24, 2025

folkertdev commented Jan 28, 2025

compiler-errors commented Feb 6, 2025

bors commented Feb 6, 2025

disallow `repr()` on invalid items #133925

disallow `repr()` on invalid items #133925

folkertdev commented Dec 5, 2024 •

edited

Loading

jdonszelmann commented Dec 5, 2024 •

edited

Loading

rfcbot commented Jan 8, 2025 •

edited

Loading