Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 4.1.1 master #9

Merged
merged 82 commits into from
Feb 19, 2024
Merged

Merge 4.1.1 master #9

merged 82 commits into from
Feb 19, 2024

Conversation

quipo
Copy link

@quipo quipo commented Feb 15, 2024

Update to 4.1.1 so we can update the platform to 4.1.1 as well. See: https://github.com/sensat/platform/pull/1932

Same process as before:

git co main
git pull
git remote add upstream git@github.com:visgl/loaders.gl.git
git fetch upstream
git co -b 'merge-4.1.1-master'
git merge --no-ff v4.1.1
# fix merge conflicts
yarn install
yarn build
git commit
git push -u origin merge-4.1.1-master

Includes recent implicit tiles fix.

ibgreen and others added 30 commits November 21, 2023 18:09
Signed-off-by: Xun Li <lixun910@gmail.com>
Co-authored-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7918703076

Details

  • -728 of 4486 (83.77%) changed or added relevant lines in 517 files are covered.
  • 38 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+1.4%) to 68.857%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/3d-tiles/src/lib/filesystems/tiles-3d-archive-file-system.ts 5 6 83.33%
modules/arrow/src/tables/convert-arrow-to-geojson-table.ts 19 20 95.0%
modules/bson/src/lib/encoders/encode-bson.ts 3 4 75.0%
modules/draco/src/workers/draco-writer-worker.ts 0 1 0.0%
modules/geotiff/src/lib/load-geotiff.ts 11 12 91.67%
modules/gis/src/lib/tables/convert-table-to-geojson.ts 2 3 66.67%
modules/json/src/geojson-loader.ts 2 3 66.67%
modules/mvt/src/lib/types.ts 0 1 0.0%
modules/parquet/src/parquet-loader.ts 90 91 98.9%
modules/tile-converter/src/i3s-server/routes/slpk-router.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
modules/arrow/src/geoarrow/convert-geoarrow-to-binary-geometry.ts 1 97.77%
modules/arrow/src/workers/triangulation-worker.ts 1 80.0%
modules/parquet/src/lib/wasm/load-wasm.ts 1 0.0%
modules/tiles/src/tileset/tileset-3d.ts 1 70.89%
modules/wkt/src/lib/parse-wkb.ts 1 94.63%
modules/worker-utils/src/lib/process-utils/child-process-proxy.ts 1 78.34%
modules/core/src/lib/api/encode.ts 2 54.15%
modules/mvt/src/mvt-source.ts 2 54.51%
modules/schema/src/lib/table/simple-table/row-utils.ts 2 46.03%
modules/3d-tiles/src/lib/parsers/parse-3d-tile-header.ts 4 91.76%
Totals Coverage Status
Change from base Build 7789825884: 1.4%
Covered Lines: 72625
Relevant Lines: 106546

💛 - Coveralls

@quipo quipo mentioned this pull request Feb 15, 2024
Copy link

@Kaapp Kaapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lorenzo!

@quipo quipo merged commit 0edf9b4 into master Feb 19, 2024
2 checks passed
@quipo quipo deleted the merge-4.1.1-master branch February 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.