Role Types

[Errant-4]

About the PR

Role types are the roles that each player is intended to fill in a round, clarifying what they are expected and allowed to do. Previously these roles were only listed in the Server Rules and on the Ghost Roles interface. Solo / Team antagonist status was not explicitly given for either Roundstart and Converted antagonists. At any time there was no way for the player to check their current role unless they were given an antag briefing/objectives, and inferred it from that (possibly incorrectly, in the case of Solo/Team Antag - people seem to mistake Traitors for a team with some frequency, not helped by the fact that traitor REINFORCEMENTS are in fact team antagonists).

This PR now solidifies role types into actual prototypes that exist ingame. They can each have a custom color and a localized name. A specific role type is now explicitly associated with each mind at all times, and the player can always check their current role on the character screen. When their role type changes, it is immediately updated on the character screen and there is also a notification in chat.

Altered Silicon is a new role tpye. It is identical to Silicon as far as rules go, and merely serves to indicate that this is essentially an "antagonistic" silicion, due to their laws. Any borg brain in an emagged, ion-stormed, or Syndacate Assault borg body will be Altered Silicon until removed from the body.

Admin stuff

Admins now see the exact role types of each player on the Players tab of the admin menu, and the admin overlay now also shows the exact role type of an antagonist*, rather than just saying ANTAG (the current style of the overlay is still available if the ui.admin_overlay_classic cvar is set to true)

(What IS an antagonist? Previously, mind roles could either be an antag or not. This was configured somewhat inconsistently, for example "obvious" antags like Syndicats or Assault Borgs do not have ANTAG status on live. From now on, the admin overlay simply has a list of role types that it shows. Currently these are: Solo Antagonist, Team Antagonist, Free Agent and Altered Silicon. In the future, the UI my be updated so that each admin can customize what role types should be shown on the overlay

Known Issues and Planned Improvements

For now, Syndicate Assault Cyborgs do not correctly get their Altered Silicon role type from their chassis. Instead it is set directly on their positronic brain. This means if their brain is removed, they will continue to be indicated as altered silicon, despit not having any actually laws, dangerous or otherwise ((and thus acting as Free Agents)). Since Altered Silicon are expected to act exactly the same as Silicon and follow their listed laws anyway, (and a removed borg brain cant really DO anything, anyway) this is not a major issue. A somewhat larger issue would be if any other borg brain was put into the Assault Borg, which would continue to have "antagonistic laws" but not switch to Altered Silicon. Silicon rules would of course still require the player to obey the antagonistic laws, so this highly unlikely scenario would, at worst, create some confusion. It will be fixed at a later time, probably after #33311 is merged)

The character screen does not currently provide any details about the role types, I might give them a mouseover tooltip with the details of the current role, possibly with clicking on the roletype opening the relevant part of the server rules if that is possible. Or we could put Role Types in the guidebook

The list of roles that the Admin Overlay displays could be made editable, so that each admin can customize what role types should be shown on the overlay

It should be possible to create a command which triggers the Chat Role Update for a player, displaying their current role in their chat. This could for example be used as a sort of "bwoinkless warning" on a Crew Aligned player to remind them of their role

Why / Balance

This PR aims for the requirements originally set by Chief Engineer/then-headmin-consensus
Fixes #28090

Technical details

Each time a mind role is added to or removed from a mind entity, the game checks what the mind's role type should be. The current selection method is that the newest mind role (that actually specifies a type) takes precedence, and if no mind role specifies a role type, then it defaults to Crew Aligned.

How does this actually work in practice:
A player spawns at the start of the round. Their mind is by default on the Crew Aligned role type. It is immediately given a Job Role, which specifies no role type. The role update check is ran, and due to no roles to choose from, it chooses Crew Aligned. Since this matches it's current role type, no update event happens.
The same player is then immediately activated as a Thief, which gives them the Thief Role mindrole. This mind role is Solo Antagonist. The new role type check finds 1 role type, takes the newest one, and sets the mind to Solo Antagonist. The player gets a line in chat about their new role type, in addition to the old thief briefing.
The player is later flashed by a head revolutionary, which adds the Revolutionary mind role. It is now the newest one, and sets the mind to Team Antagonist.
The player is later given a mindshield implant, which removes the Revolutionary mind role. Thus the mind is switched to the now-newest role type, and goes back to Solo Antagonist.
If the mindshield implant was instead a theoretical "Loyalty Implant", which added a "Nanotrasen Brainwashing" mind role, which would be Crew Aligned, then it could override the mind's pre-revolution antag role and set it to Crew Aligned

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

All new ghost roles or toggleable ghostroles that are not Crew Aligned must specify their role type on the entity prototype. Add a mind role prototype in the MindRoles datafield in GhostRoleComponent or ToggleableGhostRoleComponent. See the entity prototype of any updated hostile ghostrole for an example. Generic mind roles are provided in mind_roles.yml and should cover ghostrole needs without having to make a new prototype.

Any game rule systems which handle turning someone into some sort of traitor or free agent must add a MindRole which has the desired role type. See ZombieSystem.Transform or SiliconLawSystem for an example.

RoleAddedEvent and RoleRemovedEvent no longer contains the antag state of the role being added or removed. Instead it now reports if the mob's active role type has changed with the addition/removal of this role type. Filtering out "unimportant" role events from AdminSystem was the only purpose that the antag field seemed to provide, this is now checked more accurately.

Changelog
🆑 Errant

• add: Players are now informed in chat every time their role type changes, and can also see their current role type on the character window.
  ADMIN:
• tweak: The Admin Menu and Admin Overlay now shows the specific role types of players and antagonists, respectively. The old admin overlay can still be used with cvar ui.admin_overlay_classic true

[slarticodefast]

I found a few more things.
I will still have to do some in-game testing, maybe we can include a few admins for that.
But we are getting there.

[slarticodefast]

Looks good to me!