Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech is relayed by holopad holograms #33978

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Speech is relayed by holopad holograms #33978

wants to merge 3 commits into from
+41 −10

Conversation

chromiumboy
Copy link
Contributor

@chromiumboy chromiumboy commented Dec 21, 2024 •
edited
Loading

About the PR

A small change to holopads - speech is now relayed by their hologram rather than the holopad unit itself

Why / Balance

It seems more natural that the hologram appears to speak, even though the sound is coming from a machine. It also shortens the speaker's name, so it takes up less space in the world space and the chat window

Works towards fulfilling #33954

Technical details

A new field was added to TelephoneComponent, allowing telephones to nominate another entity with the speech component to act as its speaker. TelephoneSystem checks for these speakers first when attempting to send in character messages, using the telephone as the speaker if it does not find one

Media

holopad_hologram_speech

Requirements

Breaking changes

N/A

Changelog

N/A

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Dec 21, 2024
@chromiumboy chromiumboy added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Chat Area: Chat-related features and changes, most likely technical A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 21, 2024
@chromiumboy chromiumboy mentioned this pull request Dec 24, 2024
Open
13 tasks
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 28, 2024
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Chat Area: Chat-related features and changes, most likely technical A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chromiumboy