Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix communication console menu #33655

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix communication console menu #33655

merged 2 commits into from
Dec 20, 2024

Conversation

VlaDOS1408
Copy link
Contributor

@VlaDOS1408 VlaDOS1408 commented Nov 29, 2024 •
edited by slarticodefast
Loading

Subdivision of: #33632 pr

About the PR

fix resizable

Media

Before

2024-11-28_23-44-54
2024-11-28_23-45-03

After

UIUpdate_CommCons
UIUpdate_CommCons-Big

Requirements

Changelog

🆑

  • fix: The Communication Console UI is now resizable.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Nov 29, 2024
@VlaDOS1408 VlaDOS1408 changed the title Fix communication menu Fix communication console menu Nov 29, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 29, 2024
slarticodefast
slarticodefast approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than before!
Thank you for your contribution!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 29, 2024
@slarticodefast slarticodefast self-assigned this Nov 29, 2024
chromiumboy
chromiumboy requested changes Dec 3, 2024
View reviewed changes
Content.Client/Communications/UI/CommunicationsConsoleMenu.xaml
Comment on lines +12 to +17
<TextEdit Name="MessageInput"
VerticalExpand="True"
HorizontalExpand="True"
VerticalAlignment="Stretch"
HorizontalAlignment="Stretch"
MinHeight="100"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a small margin so that the input text doesn't overlap with the scroll bar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so where I'm going to add that is the TextEdit element.

@chromiumboy
Copy link
Contributor

chromiumboy commented Dec 3, 2024 •
edited
Loading

I like the updated look, just one small thing from me

@TheShuEd
Copy link
Member

Due to the author being banned from the repository, we will be closing this PR. Other contributors may continue the work by opening up a new PR. Should the author successfully appeal the ban, the PR may be re-opened.

@TheShuEd TheShuEd closed this Dec 20, 2024
@chromiumboy chromiumboy reopened this Dec 20, 2024
@chromiumboy
Copy link
Contributor

chromiumboy commented Dec 20, 2024 •
edited
Loading

I think this can just be merged as is

Just waiting for checks to pass

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Dec 20, 2024
@chromiumboy chromiumboy merged commit 4c0a134 into space-wizards:master Dec 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@chromiumboy chromiumboy chromiumboy approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VlaDOS1408 @chromiumboy @TheShuEd @slarticodefast @beck-thompson