Tweaks for the holopad

[chromiumboy]

About the PR

A collection of minor tweaks and bug fixes for the holopad before it gets merged into stable

Why / Balance

This PR changes the following:

• The listening range on holopads has been reduced from 4 tiles to 2.5 tiles. This is to reduce the amount of background chatter they might pick up when people make a holo-call in a public area
• Regular holopads can now only call other regular holopads that are on the same grid
• Long-range holopads can now call long-range and quantum entangling holopads that are on the same map but different grids (does not function during FTL, even if warping to a different part of the same map)
• Quantum entangling holopads can now call long-range and quantum holopads on any map, so long as they are on different grids (i.e., they have been turned into an upgraded version of the long-range holopad. Can functions during FTL)
• Added a new holopad variant, the bluespace holopad. It can connect with any holopad, wherever they are, but can't be contacted in turn (even by other bluespace holopads). This is the replacement for the original quantum entangling holopad. To be used for admemes, or if you want to give one to the nukies to taunt the crew with
• AIs can now project themselves from the long-range and quantum entangling holopads on their station. This is for parity with regular holopads
• AIs now get an error pop-up if they try to answer a holo-call originating from another map. This is to clear up any confusion AI players might have as to why the call won't connect
• AIs no longer have duplicated holopad UI windows when they answer a summons to another holopad
• The draw depth of the holopad sprite has been corrected so it matches other floor objects

Technical details

N/A

Media

N/A

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Just in case someone is using this code already...

Entities using the telephone system/component now handle transmission ranges differently

Firstly, TelephoneRange.Long has been removed; any instances should be replaced with TelephoneRange.Map

Secondly, additional options for configuring which telephones can contact other telephones - CompatibleRanges (List<TelephoneRange>) and IgnoreTelephonesOnSameGrid (bool)

Where TransmissionRange determines which telephones are in range of a source, CompatibleRanges is the whitelist that determines which of these it can initiate a call with (based on the receivers' own TransmissionRange). For example, long-range holopads have a TransmissionRange of TelephoneRange.Map, so they can potentially contact any other holopads on the map. However, they have CompatibleRanges of TelephoneRange.Map and TelephoneRange.Unlimited, so they can only connect to other holopads that have a TransmissionRange of TelephoneRange.Map or TelephoneRange.Unlimited (e.g., other long-range and quantum entangling holopads)

IgnoreTelephonesOnSameGrid, on the other hand, when set to true, will prevent telephones from contacting any other telephones on the same grid. This bool will be ignored if the telephone has a TransmissionRange of TelephoneRange.Grid

Changelog

N/A

[Stewie523]

I think you should be able to change the listening radius of a holopad in game up to a certain point.

[ScarKy0]

1. I feel like holopads shouldn't speak using their names/labels. "Holopad (BotanyStuff) (Kristopher Laborde) said, 'god this is so long...' "
   Could probbaly be reduced to saying just the character name
2. Would be nice where youre being requested from(AI) or called from(non-AI) so it would say "[Service-Botany] Kristopher Laborde (Captain) is calling" on the UI or smth along those lines

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[chromiumboy]

I think you should be able to change the listening radius of a holopad in game up to a certain point.

Yeah, there could be some additional controls on the 'in-call' screen to toggle a conference mode (which has a wider listening range) as well as a mute toggle. That would have to wait 'til later though

1. I feel like holopads shouldn't speak using their names/labels. "Holopad (BotanyStuff) (Kristopher Laborde) said, 'god this is so long...' "
   Could probbaly be reduced to saying just the character name
2. Would be nice where youre being requested from(AI) or called from(non-AI) so it would say "[Service-Botany] Kristopher Laborde (Captain) is calling" on the UI or smth along those lines

The name + label was to replicate how hand held radios handle relayed message but I see your point, I'll think on it. Having the name of the holopad the caller is coming from is a good idea. Might also have to wait on this one

[ScarKy0]

Oh also, its not really needed after all (since the amount of holopads doesnt seem to be an issue) but I still think a search field would be cool

[chromiumboy]

Oh also, its not really needed after all (since the amount of holopads doesnt seem to be an issue) but I still think a search field would be cool

Thats good to know but I'll keep the filter in mind for the furture

[slarticodefast]

I noticed don't know enough about this system yet to give it a proper review.
But at least some cleanup :)

[chromiumboy]

I noticed don't know enough about this system yet to give it a proper review. But at least some cleanup :)

Since it's a brand new system, you know as much as everyone else! :D

[slarticodefast]

Summoning @SlamBamActionman so we can get it into the next release in time.