Fix borgs being able to drink from buckets and spray bottles.

[amatwiedle]

About the PR

Added additional logic to the drink system to prevent borgs with the regular or advanced cleaning module being able to drink the liquid inside buckets and spray bottles in their hand slots.

Why / Balance

Fixes #30775.

Technical details

DrinkSystem

• TryDrink now checks for if the entity attempting to drink is a borg.

Media

janiborg_drink_fix_compressed.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• fix: Borgs can no longer drink from tools provided by modules.

[pheenty]

No need to run multiple checks, just use OR operator

[pheenty]

 if (!HasComp<BodyComponent>(target) || (HasComp<BorgChassisComponent>(target))
            return false;

[amatwiedle]

I did it that way for readability reasons over code conciseness, but it's a simple change I can make.
.

[pheenty]

It is still readable. Take a look at Content.Client/Doors/AirlockSystem.cs, line 93 for example

[slarticodefast]

I don't think cyborgs should be hardcoded into the DrinkSystem. How does the FoodSystem handle this?

[amatwiedle]

I don't think cyborgs should be hardcoded into the DrinkSystem. How does the FoodSystem handle this?

The food system checks for an UnremoveableComponent and returns out of the TryFeed method if it is present. All items given to borgs via ItemBorgModuleComponent are given UnremoveableComponent, which prevents them from eating. DrinkSystem has no such check, should I use that approach instead?

[amatwiedle]

It is also worth mentioning that the FoodSystem checks for a StomachComponent in the TryFeed method, which borgs do not have, while the DrinkSystem does not. If an entity gets past all the checks in TryDrink, then it assumes it has a stomach to put the drink into, which is why the solution is deleted from existence in the case of borgs.

[pheenty]

Seems fine now

[osjarw]

I believe this should be done with an event, a while back I tried to do something similar.

#27066 (comment)

Artifacts shouldn't be hardcoded into ghost code as it just becomes a big mess for forks, probably put in a bool on the component instead or use an event.

[slarticodefast]

Looks good to me and works as intended.