-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chem master UI #33328
Chem master UI #33328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray, some UI love and care without any balancing concerns. More of this sort of thing please.
Probably want to make a Control for striped lists at some point, also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Note for the future: stripey item lists as own control element
I like the new appearance. Is there a reason why you didn't do the input container as well? |
Oops, didn't notice the input container didn't get the glow-up too. Gonna request that changed too for full approval, oops. |
resolved, see EDIT. |
I think it would look better if i could shape the colored elements to mirror the rightmost button and/or resemble the left side of the old 1u button, but I've no idea how to accomplish this in a manner that isn't perverse. If anyone who knows more about Style sheets than me can offer some wisdom that would be much appreciated. Edit: I do not feel strongly enough about this to put off merging if maintainers find the PR acceptable/desireable as is. |
…nheight specification from verticalstretch elements
just found a bug that lets it make more pills than fit in the canister, this ejects the pills, will fix this later today, maybe put off review until next push. |
HOLY PEAK PLEASE MERGE THIS I BEG |
About the PR
Added striped rows, as well as a small reagent colored bar for each reagent to the Chem Master buffer and input buffer UI.
Left side of Chem Master Buffer Buttons have been made into plain rectangles, in order to look better with the new colored bars.
Pill and bottle dosages in the output tab will now default to the largest valid value, rather than zero.
Why / Balance
This should not have an appreciable effect on game balance, but it should make the eyes of myself and other chemists very happy, and should make using Chem Masters to actually make pills slightly more tolerable.
Technical details
Not counting comments, and lines that seem to have been counted as additions because they were moved slightly, this PR contains probably less than 10 lines of novel code.
Edit: Changing the input buffer was more involved, and much was restructured, still not a large change, and limited to the one xaml.cs
Edit2: The vast majority of the file has now been desecrated in one manner or another.
Media!
Visuals as of latest commit:
Requirements
Breaking changes
It is my fondest hope that this breaks absolutely nothing.
Changelog