Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SpawnTableOnUse #32620

Merged
merged 5 commits into from
Dec 16, 2024
Merged

add SpawnTableOnUse #32620

merged 5 commits into from
Dec 16, 2024

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Oct 3, 2024 •
edited
Loading

About the PR

like present code but not shit

Why / Balance

needed downstream

Technical details

no price because thats ridiculous (spawn every possible item check its price and delete it) and should probably be removed from present too

also added Positional field to all EmitSoundOnX components so it can work when entity is deleted

@deltanedas
Copy link
Contributor Author

bump

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
slarticodefast
slarticodefast requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an admin log the same way SpawnItemsOnUseSystem does. The rest looks good to me.

@slarticodefast slarticodefast self-assigned this Nov 19, 2024
@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 19, 2024
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Nov 27, 2024
@slarticodefast
Copy link
Member

you forgot the namespace import

@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 27, 2024
@slarticodefast
Copy link
Member

Are you coming back to this?

@deltanedas
Copy link
Contributor Author

bruh

@deltanedas
Copy link
Contributor Author

me when github doesnt give me notif 2 weeks ago

slarticodefast
slarticodefast approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@slarticodefast slarticodefast removed the S: Awaiting Changes Status: Changes are required before another review can happen label Dec 12, 2024
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Dec 12, 2024
@TheShuEd TheShuEd merged commit 2635888 into space-wizards:master Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centronias Centronias Centronias requested changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deltanedas @slarticodefast @Centronias @SlamBamActionman @TheShuEd @ScarKy0