Prevent pulling when teleporting

[thetolbean]

About the PR

If a user attempts to teleport, either through the space ninja's katana or a scram implant, they will drop said item before teleporting

Why / Balance

Fix #33243 and prevent teleports from being extended to pulled objects

Technical details

Adds a check to both OnScramImplant & OnDash that check if the user is pulling an item, and if so, attempt to cancel the pull before the teleport

Media

2024-11-11.00-31-10.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

• tweak: Teleporting or dashing now causes you to stop pulling objects.

[K-Dynamic]

I did say the issue was present with scram implants, but I also heard it was funny to scram into space with a secoff that was dragging you earlier, so it might be worth leaving that in considering its unpredictability

[slarticodefast]

Tested and works as intended, thanks for the PR!

I did say the issue was present with scram implants, but I also heard it was funny to scram into space with a secoff that was dragging you earlier, so it might be worth leaving that in considering its unpredictability

While I agree with you that it would be funnier to keep, this has too many potential edge cases where it could cause bugs with pulling.

[MilenVolf]

Does it also prevent pulling if user or target is being teleported? For example, by bluespace anomaly

[slarticodefast]

Does it also prevent pulling if user or target is being teleported? For example, by bluespace anomaly

The bluespace anomaly is a separate system, but it likely has the same problem.

[thetolbean]

Does it also prevent pulling if user or target is being teleported? For example, by bluespace anomaly

Yes, as Slarti said the bluespace system is separate
With being pulled however, the scram implant already had a check in place to escape from being pulled. The dash does not, so I will be adding that shortly

[NoElkaTheGod]

It was kinda funny though. But removing this is probably for the better.

[thetolbean]

@slarticodefast Got your recommendations included and tested

[slarticodefast]

Thanks!

[thetolbean]

And I did perform testing on the bluespace scenarios, both the linked lockers and bluespace anom.
Both cancel your pulls if you are dragging something.
The items come along in the locker if they are also closed in, but you are not pulling them when you leave the other locker

[thetolbean]

It was kinda funny though. But removing this is probably for the better.

Yeah, I agree. There's nothing like stealing an entire computer (or person) in the blink of an eye
Although it definitely needs to be removed for balancing

[chromiumboy]

My thoughts are that the pulling system should listen for when a puller's transform get updated, and if the displacement is outside a certain tolerance, the pull is canceled. That way all teleport cases would be covered