Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] test BI deprecation removal size #9570

Closed
wants to merge 6 commits into from
Closed

[DO NOT MERGE] test BI deprecation removal size #9570

wants to merge 6 commits into from

Conversation

amk-stripe
Copy link
Collaborator

Summary

[DO NOT MERGE] test BI deprecation removal size

Motivation

testing the size of the removed code, since the original emerge tools run failed

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │            uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff       
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
      dex │   3.8 MiB │   3.9 MiB │ +60.4 KiB │   8.4 MiB │   8.5 MiB │ +119.7 KiB 
     arsc │   2.3 MiB │   2.3 MiB │  +2.5 KiB │   2.3 MiB │   2.3 MiB │   +2.5 KiB 
 manifest │     5 KiB │   5.1 KiB │     +69 B │  24.9 KiB │  25.6 KiB │     +656 B 
      res │ 902.3 KiB │ 934.2 KiB │ +31.9 KiB │   1.4 MiB │   1.5 MiB │  +66.7 KiB 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │     6 MiB │        0 B 
    asset │   1.6 MiB │   1.6 MiB │  +1.3 KiB │   1.6 MiB │   1.6 MiB │   +1.3 KiB 
    other │ 199.8 KiB │ 201.2 KiB │  +1.4 KiB │ 440.1 KiB │ 443.2 KiB │     +3 KiB 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
    total │  11.4 MiB │  11.5 MiB │ +97.7 KiB │  20.2 MiB │  20.4 MiB │   +194 KiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 39771 │ 40480 │ +709 (+5398 -4689)   
   types │ 13720 │ 13850 │ +130 (+4815 -4685)   
 classes │ 11412 │ 11517 │ +105 (+3968 -3863)   
 methods │ 58632 │ 59154 │ +522 (+31414 -30892) 
  fields │ 38947 │ 39385 │ +438 (+23945 -23507) 

 ARSC    │ old  │ new  │ diff         
─────────┼──────┼──────┼──────────────
 configs │  242 │  242 │   0          
 entries │ 6190 │ 6212 │ +22 (+22 -0)
APK 
      compressed      │      uncompressed      │                                           
──────────┬───────────┼───────────┬────────────┤                                           
 size     │ diff      │ size      │ diff       │ path                                      
──────────┼───────────┼───────────┼────────────┼───────────────────────────────────────────
  3.9 MiB │ +60.4 KiB │   8.5 MiB │ +119.7 KiB │ ∆ classes.dex                             
  5.8 KiB │  +5.8 KiB │  12.8 KiB │  +12.8 KiB │ + res/vb.xml                              
    5 KiB │    +5 KiB │  10.8 KiB │  +10.8 KiB │ + res/ry.xml                              
  4.1 KiB │  +4.1 KiB │   8.6 KiB │   +8.6 KiB │ + res/OC.xml                              
  2.6 KiB │  +2.6 KiB │   5.3 KiB │   +5.3 KiB │ + res/eX.xml                              
  2.3 MiB │  +2.5 KiB │   2.3 MiB │   +2.5 KiB │ ∆ resources.arsc                          
  2.5 KiB │  +2.5 KiB │   5.5 KiB │   +5.5 KiB │ + res/ZY.xml                              
  1.4 KiB │  +1.4 KiB │   3.1 KiB │   +3.1 KiB │ + res/iK.xml                              
  7.8 KiB │  +1.4 KiB │   7.7 KiB │   +1.4 KiB │ ∆ assets/dexopt/baseline.prof             
  1.3 KiB │  +1.3 KiB │   2.6 KiB │   +2.6 KiB │ + res/_5.xml                              
  1.1 KiB │  +1.1 KiB │   2.2 KiB │   +2.2 KiB │ + res/uM.xml                              
  1.1 KiB │  +1.1 KiB │   2.3 KiB │   +2.3 KiB │ + res/Jp.xml                              
  1.1 KiB │  +1.1 KiB │   2.4 KiB │   +2.4 KiB │ + res/8B.xml                              
    936 B │    +936 B │   1.7 KiB │   +1.7 KiB │ + res/BU.xml                              
    893 B │    +893 B │   1.5 KiB │   +1.5 KiB │ + res/CD.xml                              
    834 B │    +834 B │   1.8 KiB │   +1.8 KiB │ + res/So.xml                              
 50.4 KiB │    +718 B │   119 KiB │   +1.5 KiB │ ∆ META-INF/MANIFEST.MF                    
 53.7 KiB │    +709 B │ 119.1 KiB │   +1.5 KiB │ ∆ META-INF/CERT.SF                        
    687 B │    +687 B │   1.2 KiB │   +1.2 KiB │ + res/mo.xml                              
    686 B │    +686 B │   1.5 KiB │   +1.5 KiB │ + res/SP.xml                              
    684 B │    +684 B │   1.2 KiB │   +1.2 KiB │ + res/Tj.xml                              
    531 B │    +531 B │     876 B │     +876 B │ + res/in.xml                              
    525 B │    +525 B │     932 B │     +932 B │ + res/8B1.xml                             
    354 B │    +354 B │     504 B │     +504 B │ + res/rJ.xml                              
    127 B │    +127 B │       5 B │       +5 B │ + META-INF/services/w9.v                  
    127 B │    +127 B │       5 B │       +5 B │ + META-INF/services/x9.a                  
          │    -127 B │           │       -5 B │ - META-INF/services/u9.v                  
          │    -127 B │           │       -5 B │ - META-INF/services/v9.a                  
  5.1 KiB │     +69 B │  25.6 KiB │     +656 B │ ∆ AndroidManifest.xml                     
  1,007 B │     -27 B │     875 B │      -27 B │ ∆ assets/dexopt/baseline.profm            
    964 B │      +3 B │   2.7 KiB │        0 B │ ∆ res/ZW.xml                              
    459 B │      -3 B │     824 B │        0 B │ ∆ res/e-.xml                              
    851 B │      +2 B │   1.8 KiB │        0 B │ ∆ res/8Q.xml                              
    954 B │      +2 B │   2.5 KiB │        0 B │ ∆ res/de.xml                              
    544 B │      -2 B │     952 B │        0 B │ ∆ res/zR.xml                              
    539 B │      +2 B │     952 B │        0 B │ ∆ res/zd.xml                              
    271 B │      -1 B │     120 B │        0 B │ ∆ META-INF/version-control-info.textproto 
    811 B │      -1 B │   2.3 KiB │        0 B │ ∆ res/1w.xml                              
    750 B │      +1 B │   1.5 KiB │        0 B │ ∆ res/3O.xml                              
    443 B │      -1 B │     816 B │        0 B │ ∆ res/3h.xml                              
    464 B │      -1 B │     656 B │        0 B │ ∆ res/5l.xml                              
    742 B │      -1 B │   1.5 KiB │        0 B │ ∆ res/9V.xml                              
    763 B │      -1 B │   1.6 KiB │        0 B │ ∆ res/A0.xml                              
  1.1 KiB │      -1 B │   3.4 KiB │        0 B │ ∆ res/B4.xml                              
  1.1 KiB │      -1 B │   3.2 KiB │        0 B │ ∆ res/B7.xml                       
...✂
MANIFEST 
@@ -253,2 +253,17 @@
         android:exported="false"
+        android:name="com.stripe.android.view.AddPaymentMethodActivity"
+        android:theme="@style/StripeDefaultTheme"
+        />
+    <activity
+        android:exported="false"
+        android:name="com.stripe.android.view.PaymentMethodsActivity"
+        android:theme="@style/StripeDefaultTheme"
+        />
+    <activity
+        android:exported="false"
+        android:name="com.stripe.android.view.PaymentFlowActivity"
+        android:theme="@style/StripeDefaultTheme"
+        />
+    <activity
+        android:exported="false"
         android:name="com.stripe.android.view.PaymentAuthWebViewActivity"
DEX 
STRINGS:

   old   │ new   │ diff               
  ───────┼───────┼────────────────────
   39771 │ 40480 │ +709 (+5398 -4689) 
  
  + 
�
  �


  +  => 
  +  Pager class: 
  +  Pager id: 
  +  Problematic adapter: 
  +  too small; defaulting to 1
  + ' is not a valid country code
  + (((?:(?i:http|https|rtsp)://(?:(?:[a-zA-Z0-9\_\-\_\.\+\!\*\'\(\)\,\;\?\&\=]|(?:\%[a-fA-F0-9]{2})){1,64}(?:\:(?:[a-zA-Z0-9\_\-\_\.\+\!\*\'\(\)\,\;\?\&\=]|(?:\%[a-fA-F0-9]{2})){1,25})?\@)?)?(?:
  + ((25[0-5]|2[0-4][0-9]|[0-1][0-9]{2}|[1-9][0-9]|[1-9])\.(25[0-5]|2[0-4][0-9]|[0-1][0-9]{2}|[1-9][0-9]|[1-9]|0)\.(25[0-5]|2[0-4][0-9]|[0-1][0-9]{2}|[1-9][0-9]|[1-9]|0)\.(25[0-5]|2[0-4][0-9]|[0-1][0-9]{2}|[1-9][0-9]|[0-9]))
  + ((?:\b|_|^)(?:(?:(?i:http|https|rtsp)://(?:(?:[a-zA-Z0-9\_\-\_\.\+\!\*\'\(\)\,\;\?\&\=]|(?:\%[a-fA-F0-9]{2})){1,64}(?:\:(?:[a-zA-Z0-9\_\-\_\.\+\!\*\'\(\)\,\;\?\&\=]|(?:\%[a-fA-F0-9]{2})){1,25})?\@)?)(?:
  + ((?:\b|_|^)(?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]\+\-_%'](?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]\+\-_%'\.]{0,62}[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]\+\-_%'])?@(?=.{1,255}(?:\s|_|^))([a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]](?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]_\-]{0,61}[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]]){0,1}\.)+(xn\-\-[\w\-]{0,58}\w|[a-zA-Z[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]]{2,63}))(?:\b|_|^))
  + ((?:\b|_|^)(?<!:\/\/)((?:
  + (([a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]](?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]_\-]{0,61}[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]]){0,1}\.)+(xn\-\-[\w\-]{0,58}\w|[a-zA-Z[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]]{2,63})|
  + (?:(?:(?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]](?:[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]_\-]{0,61}[a-zA-Z0-9[ -퟿豈-﷏ﷰ-￯𐀀-🿽𠀀-𯿽𰀀-𿿽񀀀-񏿽񐀀-񟿽񠀀-񯿽񰀀-񿿽򀀀-򏿽򐀀-򟿽򠀀-򯿽򰀀-򿿽󀀀-󏿽󐀀-󟿽󡀀-󯿽&&[^ [ - ]

 　]]]){0,1}\.)+(?:(?:(?:aaa|aarp|abb|abbott|abbvie|abc|able|abogado|abudhabi|academy|accenture|accountant|accountants|aco|actor|ads|adult|aeg|aero|aetna|afl|africa|agakhan|agency|aig|airbus|airforce|airtel|akdn|alibaba|alipay|allfinanz|allstate|ally|alsace|alstom|amazon|americanexpress|americanfamily|amex|amfam|amica|amsterdam|analytics|android|anquan|anz|aol|apartments|app|apple|aquarelle|arab|aramco|archi|army|arpa|art|arte|asda|asia|associates|athleta|attorney|auction|audi|audible|audio|auspost|author|auto|autos|avianca|aws|axa|azure|a[cdefgilmoqrstuwxz])|(?:baby|baidu|banamex|bananarepublic|band|bank|bar|barcelona|barclaycard|barclays|barefoot|bargains|baseball|basketball|bauhaus|bayern|bbc|bbt|bbva|bcg|bcn|beats|beauty|beer|bentley|berlin|best|bestbuy|bet|bharti|bible|bid|bike|bing|bingo|bio|biz|black|blackfriday|blockbuster|blog|bloomberg|blue|bms|bmw|bnpparibas|boats|boehringer|bofa|bom|bond|boo|book|booking|bosch|bostik|boston|bot|boutique|box|bradesco|bridgestone|broadway|broker|brother|brussels|build|builders|business|buy|buzz|bzh|b[abdefghijmnorstvwyz])|(?:cab|cafe|cal|call|calvinklein|cam|camera|camp|canon|capetown|capital|capitalone|car|caravan|cards|care|career|careers|cars|casa|case|cash|casino|cat|catering|catholic|cba|cbn|cbre|cbs|center|ceo|cern|cfa|cfd|chanel|channel|charity|chase|chat|cheap|chintai|christmas|chrome|church|cipriani|circle|cisco|citadel|citi|citic|city|cityeats|claims|cleaning|click|clinic|clinique|clothing|cloud|club|clubmed|coach|codes|coffee|college|cologne|com|comcast|commbank|community|company|compare|computer|comsec|condos|construction|consulting|contact|contractors|cooking|cool|coop|corsica|country|coupon|coupons|courses|cpa|credit|creditcard|creditunion|cricket|crown|crs|cruise|cruises|cuisinella|cymru|cyou|c[acdfghiklmnoruvwxyz])|(?:dabur|dad|dance|data|date|dating|datsun|day|dclk|dds|deal|dealer|deals|degree|delivery|dell|deloitte|delta|democrat|dental|dentist|desi|design|dev|dhl|diamonds|diet|digital|direct|directory|discount|discover|dish|diy|dnp|docs|doctor|dog|domains|dot|download|drive|dtv|dubai|dunlop|dupont|durban|dvag|dvr|d[ejkmoz])|(?:earth|eat|eco|edeka|edu|education|email|emerck|energy|engineer|engineering|enterprises|epson|equipment|ericsson|erni|
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff         
  ──────┼──────┼──────────────
   6190 │ 6212 │ +22 (+22 -0) 
  + drawable/stripe_ic_bank_affin
  + drawable/stripe_ic_bank_alliance
  + drawable/stripe_ic_bank_ambank
  + drawable/stripe_ic_bank_bsn
  + drawable/stripe_ic_bank_cimb
  + drawable/stripe_ic_bank_hong_leong
  + drawable/stripe_ic_bank_hsbc
  + drawable/stripe_ic_bank_islam
  + drawable/stripe_ic_bank_kfh
  + drawable/stripe_ic_bank_maybank
  + drawable/stripe_ic_bank_muamalat
  + drawable/stripe_ic_bank_ocbc
  + drawable/stripe_ic_bank_public
  + drawable/stripe_ic_bank_raykat
  + drawable/stripe_ic_bank_rhb
  + drawable/stripe_ic_bank_standard_chartered
  + drawable/stripe_ic_bank_uob
  + id/footer_container
  + id/recycler
  + id/shipping_flow_viewpager
  + layout/stripe_payment_flow_activity
  + layout/stripe_payment_methods_activity

@amk-stripe amk-stripe closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amk-stripe