forked from libsdl-org/SDL
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use now available enum values. #2
Open
bartwe
wants to merge
92
commits into
taisei-project:gpu_render
Choose a base branch
from
bartwe:bartwe/gpu_render_enum_update_0812
base: gpu_render
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use now available enum values. #2
bartwe
wants to merge
92
commits into
taisei-project:gpu_render
from
bartwe:bartwe/gpu_render_enum_update_0812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com> Co-authored-by: Ethan Lee <flibitijibibo@gmail.com> Co-authored-by: Zakary Strange <zakarystrange@gmail.com>
Always check return value of VULKAN_INTERNAL_QuerySwapchainSupport(), if 1st call to vkGetPhysicalDeviceSurfacePresentModesKHR() fails then outputDetails->formatsLength is not 0 but outputDetails->formats is still not initialised. Always free outputDetails->formats on error in VULKAN_INTERNAL_QuerySwapchainSupport(). Use correct type for allocation of commandBuffer->presentDatas. Do some allocations later to avoid memory leaks on error.
This should clarify the usage of the parameters in the Upload/Download functions.
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
…ow/SetSwapchainParameters
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
…_INTERNAL_InitBlitPipelines
Lots of missing and broken stuff, but it's a start
Akaricchi
force-pushed
the
gpu_render
branch
6 times, most recently
from
August 19, 2024 22:46
66aaf8e
to
c5fafed
Compare
Akaricchi
force-pushed
the
gpu_render
branch
4 times, most recently
from
August 29, 2024 00:26
ec68b78
to
c021268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends upon thatcosmonaut#163