Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bartwe/sdlgpu enumhardening #163

Closed
wants to merge 102 commits into from
Closed

Bartwe/sdlgpu enumhardening #163

wants to merge 102 commits into from

Conversation

bartwe
Copy link

@bartwe bartwe commented Aug 9, 2024

thatcosmonaut and others added 30 commits August 9, 2024 11:16
@thatcosmonaut @TheSpydog
@flibitijibibo @strangezakary
Add SDL_GPU
54d0db8 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
Co-authored-by: Ethan Lee <flibitijibibo@gmail.com>
Co-authored-by: Zakary Strange <zakarystrange@gmail.com>
@meyraud705 @flibitijibibo
Fix memory handling
64b1761 
Always check return value of VULKAN_INTERNAL_QuerySwapchainSupport(), if 1st call to vkGetPhysicalDeviceSurfacePresentModesKHR() fails then outputDetails->formatsLength is not 0 but outputDetails->formats is still not initialised.
Always free outputDetails->formats on error in VULKAN_INTERNAL_QuerySwapchainSupport().
Use correct type for allocation of commandBuffer->presentDatas.
Do some allocations later to avoid memory leaks on error.
@thatcosmonaut @flibitijibibo
Vulkan: Optionally load colorspace extension (thatcosmonaut#40)
d3a93db
@thatcosmonaut @flibitijibibo
include: Command buffer and swapchain usage clarification (thatcosmon…
1b534fe 
…aut#41)
@thatcosmonaut @flibitijibibo
Transfer usage restructuring and D3D11 async readback (thatcosmonaut#42)
a9a7e19
@TheSpydog @flibitijibibo
Debug API Rework (thatcosmonaut#45)
459c0cd
@flibitijibibo
gpu: Make some void*s const (thatcosmonaut#47)
e8cb4df
@thatcosmonaut @flibitijibibo
Rename transfer parameters to source and destination (thatcosmonaut#48)
25e75e0 
This should clarify the usage of the parameters in the Upload/Download functions.
@TheSpydog @flibitijibibo
Remove depthBoundsTestEnable / minDepthBounds / maxDepthBounds (thatc…
b99191d 
…osmonaut#49)
@TheSpydog @flibitijibibo
Remove support for border colors (thatcosmonaut#50)
870d61b
@flibitijibibo @TheSpydog
Rework texture/buffer location/region structs (thatcosmonaut#52)
e5f77b1 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
@flibitijibibo
clang-format update
aafba2d
@thatcosmonaut @flibitijibibo
prefer Metal backend when available (thatcosmonaut#59)
2b43f61
@TheSpydog @flibitijibibo
metal: Fix cast for CopyBufferToBuffer parameters
5db0c3c
@thatcosmonaut @TheSpydog @flibitijibibo
Move uniforms to command buffer scope (thatcosmonaut#55)
56cd8fc 
Co-authored-by: Caleb Cornett <caleb.cornett@outlook.com>
@TheSpydog @flibitijibibo
Document that swapchain parameters should be queried before ClaimWind…
ba2faab 
…ow/SetSwapchainParameters
@thatcosmonaut @flibitijibibo
SetSwapchainParameters and PrepareDriver return SDL_bool (thatcosmona…
4aabff6 
…ut#61)
@flibitijibibo
vulkan: Update for new CreateSurface return value
8c02225
@flibitijibibo
gpu: clang-format update
94638ba
@thatcosmonaut @flibitijibibo
D3D11: fix segfault in PushUniformData
635438e
@TheSpydog @flibitijibibo
Texture format swizzling (thatcosmonaut#71)
219f4d4
@flibitijibibo
Add preferLowPower param to CreateDevice (thatcosmonaut#72)
111ad03
@TheSpydog @flibitijibibo
Document resource binding order (thatcosmonaut#73)
061adce
@flibitijibibo
Add null checks to gpu.c
a667f63
@flibitijibibo
clang-format update
fb1a203
@flibitijibibo
Remove unused macro
4312704
@bartwe @flibitijibibo
Fix typo as we're testing against feature level 11_1
b044130
@bartwe @flibitijibibo
fix url to id source
88d49f6
@TheSpydog @flibitijibibo
depthStencilAttachmentInfo is allowed to be null (thatcosmonaut#75)
881f54e
@TheSpydog @flibitijibibo
metal: Push*UniformData should not rely on a bound pipeline (thatcosm…
af15506 
…onaut#76)
@bartwe
Copy link
Author

bartwe commented Aug 9, 2024 •
edited
Loading

Some NDA'd backends may need changes to match the backends listed here, the metal backend has been changed to match but has not been tested.

@bartwe
Copy link
Author

bartwe commented Aug 9, 2024

Also TheSpydog/SDL_gpu_examples#15

@bartwe bartwe mentioned this pull request Aug 12, 2024
Open
@thatcosmonaut thatcosmonaut force-pushed the bartwe/sdlgpu-enumhardening branch from 9618201 to de22d0a Compare August 12, 2024 23:27
@thatcosmonaut
Copy link
Owner

Verifying max values is fine but I don't think 0 values should be invalid.

@flibitijibibo flibitijibibo mentioned this pull request Aug 15, 2024
Merged
@bartwe bartwe closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bartwe @thatcosmonaut @meyraud705 @TheSpydog @flibitijibibo @playmer