Develop 0 8 #692
Merged
Develop 0 8 #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions' into fix/docker_setup_strategy_descriptions
Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
…iptions Fix inconsistencies in the documentation for docker setup strategy
* Fix: multiple: true for outputs including unit test * fix typing * move and fix test, add test suite docs * extend test * rename variables * fix multiple output component * fix test * add entry to changelog * extend tests * fix checking of output files with glob * expect wildcards in multiple output files * update changelog * extend documentation * try fixing docker chown * fix test * Fix indentation Co-authored-by: Hendrik Cannoodt <hendrik.cannoodt@gmail.com> * Update src/main/scala/io/viash/functionality/arguments/FileArgument.scala --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com> Co-authored-by: Hendrik Cannoodt <hendrik.cannoodt@gmail.com>
* simplify test * simplify stubrun id check * change search key * fix test
…e is silently dropped (#670) * Fix an issue where if the first resource is not a script, the resource is silently dropped * Fill in PR # * Update src/main/scala/io/viash/functionality/Functionality.scala Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com> * Add other edge case in test --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
…ount Prevent adding a trailing slash to an automounted folder
Make `generateTest` hidden Simplify: add `--just_generate` to viash ns test Remove dangling commented line Add --just_generate to viash test Add tests Correction Update regex for test Rename --just_generate -> --dry_run Make --dry_run hidden
Add `--dry_run` to `viash [ns] test` for generating test scripts - On develop_0_8
* Fix another possible cause of concurrency issues in nextflow * fill in PR # * Fix additional possible concurrency issue by defining the variable before branching Very similar code in a different file already solved this issue. * remove outdated comment * add missing defs * add missing def * add missing defs * fix typo * fix formatting * add def * add def * remove outdated comment * add more defs --------- Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
* create process from temporary file * remove outdated comment * normalize is not necessary * update changelog
* Add CLI parameter to set deterministic folder creation for tests Mainly meant to be used with --dry_run for usage in CI * Add checks to verify the folder doesn't already exist or is empty * Fix test sub-directory names in namespace context too * Add tests * rename deterministic_build_folder to deterministic_working_directory * update changelog too
* fix example in repositories * add changelog entry
The installed java image doesn't contain sbt
fix GHA when testing with macOS on ARM64
* Verify that component namespace and name combinations are unique * add PR# * Use Namespace.targetOutputPath to determine component name uniqueness Add wrapper to call targetOutputPath with config instead individual namespace and name fields * fix incorrect namespace, sort duplicate names and strip leading slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related issue(s)
Closes #xxxx
Type of Change
Checklist
Requirements:
Tests:
Documentation:
Test Environment