Project module: support pre-projected positions #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsherif
approved these changes
Jan 14, 2020
Pessimistress
force-pushed
the
x/cartesian-mercator
branch
from
299d638 to
5146fc6
Compare
tgorkin
added a commit
that referenced
this pull request
Jan 28, 2020
* master: (82 commits) fix typo in performance.md pydeck: ArcLayer, BitmapLayer, ColumnLayer examples (#4189) [React] fix missing key error (#4193) [Bug] Fix hexagon layer projection (#4173) Remove HtmlWebpackPlugin from examples/playground (#4178) @deck.gl/json: Fix bug dropping props with falsy values (#4185) Fix buffer size check in Attribute.updateBuffer (#4190) Bump luma dependency (#4191) data-filter: support double precision (#4163) Use int type for enum uniforms (#4171) [TileLayer] fix tile indices generation in edge cases (#4170) v8.1.0-alpha.1 Voodoo fix for Mac+NVIDIA bug (#4166) Remove unnecessary code from project glsl (#4162) Fix H3HexagonLayer update when viewport jumps (#4158) Refactor render tests; use stricter pass criteria (#4157) [Extension] Add source_target to brushing mode (#4150) Add offset feature to PathStyleExtension (#4126) Project module: support pre-projected positions (#4140) Repeat maps at low zoom levels (#4105) ...
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
This was referenced Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4104
Background
This PR fixes the usage of
COORDINATE_SYSTEM.CARTESIANwithWebMercatorViewport. In this case, positions are in common space instead of lng-lat. This is discussed in #3935, where the source data (mapbox vector tiles) is pre-projected to the Web Mercator plane.More generically, this is needed to support alternative 2D projections such as Stereographic, Albers, etc. For these projections, it is not feasible to do the full projection on the GPU with acceptable performance and precision. We will need to project lng-lat positions to the common space on the CPU, and then use these positions with a geospatial viewport.
Change List
coordinateSystem/projectionModecombinations in uniform calculation