Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor render tests; use stricter pass criteria #4157

Merged
merged 14 commits into from
Jan 16, 2020

Conversation

Pessimistress
Copy link
Collaborator

No description provided.

@1chandu
Copy link
Contributor

1chandu commented Jan 15, 2020

Can we just define these props (*aggregation, get*Weight) inline? It's really difficult to track down their values in a big file.

Updated, also added couple of new tests for GridLayer elevation.

@Pessimistress Pessimistress force-pushed the x/render-test-update branch 3 times, most recently from 2d348b1 to b3862cc Compare January 16, 2020 17:34
@coveralls
Copy link

coveralls commented Jan 16, 2020

Coverage Status

Coverage remained the same at 80.944% when pulling 05e51d0 on x/render-test-update into d004a38 on master.

@Pessimistress Pessimistress changed the title Stricter render tests Refactor render tests; use stricter pass criteria Jan 16, 2020
@Pessimistress Pessimistress merged commit bca2822 into master Jan 16, 2020
@Pessimistress Pessimistress deleted the x/render-test-update branch January 16, 2020 20:04
tgorkin added a commit that referenced this pull request Jan 28, 2020
* master: (82 commits)
  fix typo in performance.md
  pydeck: ArcLayer, BitmapLayer, ColumnLayer examples (#4189)
  [React] fix missing key error (#4193)
  [Bug] Fix hexagon layer projection (#4173)
  Remove HtmlWebpackPlugin from examples/playground (#4178)
  @deck.gl/json: Fix bug dropping props with falsy values (#4185)
  Fix buffer size check in Attribute.updateBuffer (#4190)
  Bump luma dependency (#4191)
  data-filter: support double precision (#4163)
  Use int type for enum uniforms (#4171)
  [TileLayer] fix tile indices generation in edge cases (#4170)
  v8.1.0-alpha.1
  Voodoo fix for Mac+NVIDIA bug (#4166)
  Remove unnecessary code from project glsl (#4162)
  Fix H3HexagonLayer update when viewport jumps (#4158)
  Refactor render tests; use stricter pass criteria (#4157)
  [Extension] Add source_target to brushing mode (#4150)
  Add offset feature to PathStyleExtension (#4126)
  Project module: support pre-projected positions (#4140)
  Repeat maps at low zoom levels (#4105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants