[Feat] Add source_target brushing mode #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshan0131
changed the title
Pessimistress
approved these changes
Jan 15, 2020
| @@ -87,6 +87,7 @@ The position used to filter each object by. One of the following: | |||
|
|
|||
| - `'source'`: Use the primary position for each object. This can mean different things depending on the layer. It usually refers to the coordinates returned by `getPosition` or `getSourcePosition` accessors. | |||
| - `'target'`: Use the secondary position for each object. This may not be available in some layers. It usually refers to the coordinates returned by `getTargetPosition` accessors. | |||
| - `'source_target'`: Use both the primary position and secondary position for each object. Show objet if either is in brushing rance. | |||
|
Needed in7.3 as well as 8.0 |
|
@heshan0131 , please go ahead and merge if ready, will publish 7.3 and 8.0 patches once this is landed. |
1chandu
pushed a commit
that referenced
this pull request
Jan 17, 2020
* added to API docs Signed-off-by: Shan He <heshan0131@gmail.com>
1chandu
pushed a commit
that referenced
this pull request
Jan 17, 2020
* added to API docs Signed-off-by: Shan He <heshan0131@gmail.com>
tgorkin
added a commit
that referenced
this pull request
Jan 28, 2020
* master: (82 commits) fix typo in performance.md pydeck: ArcLayer, BitmapLayer, ColumnLayer examples (#4189) [React] fix missing key error (#4193) [Bug] Fix hexagon layer projection (#4173) Remove HtmlWebpackPlugin from examples/playground (#4178) @deck.gl/json: Fix bug dropping props with falsy values (#4185) Fix buffer size check in Attribute.updateBuffer (#4190) Bump luma dependency (#4191) data-filter: support double precision (#4163) Use int type for enum uniforms (#4171) [TileLayer] fix tile indices generation in edge cases (#4170) v8.1.0-alpha.1 Voodoo fix for Mac+NVIDIA bug (#4166) Remove unnecessary code from project glsl (#4162) Fix H3HexagonLayer update when viewport jumps (#4158) Refactor render tests; use stricter pass criteria (#4157) [Extension] Add source_target to brushing mode (#4150) Add offset feature to PathStyleExtension (#4126) Project module: support pre-projected positions (#4140) Repeat maps at low zoom levels (#4105) ...
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
* added to API docs Signed-off-by: Shan He <heshan0131@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.