Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix H3HexagonLayer update when viewport jumps #4158

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

Pessimistress
Copy link
Collaborator

For keplergl/kepler.gl#887

Change List

  • Check if h3Distance fails
  • Tests

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 83.425% when pulling 0ce9cea on x/h3-hexagon-fix into 848420c on master.

@heshan0131
Copy link
Collaborator

Can this be in 7.3?

@Pessimistress
Copy link
Collaborator Author

Can this be in 7.3?

Yes we can patch 7.3 and 8.0

@Pessimistress Pessimistress merged commit e7aef5d into master Jan 16, 2020
@Pessimistress Pessimistress deleted the x/h3-hexagon-fix branch January 16, 2020 20:04
tgorkin added a commit that referenced this pull request Jan 28, 2020
* master: (82 commits)
  fix typo in performance.md
  pydeck: ArcLayer, BitmapLayer, ColumnLayer examples (#4189)
  [React] fix missing key error (#4193)
  [Bug] Fix hexagon layer projection (#4173)
  Remove HtmlWebpackPlugin from examples/playground (#4178)
  @deck.gl/json: Fix bug dropping props with falsy values (#4185)
  Fix buffer size check in Attribute.updateBuffer (#4190)
  Bump luma dependency (#4191)
  data-filter: support double precision (#4163)
  Use int type for enum uniforms (#4171)
  [TileLayer] fix tile indices generation in edge cases (#4170)
  v8.1.0-alpha.1
  Voodoo fix for Mac+NVIDIA bug (#4166)
  Remove unnecessary code from project glsl (#4162)
  Fix H3HexagonLayer update when viewport jumps (#4158)
  Refactor render tests; use stricter pass criteria (#4157)
  [Extension] Add source_target to brushing mode (#4150)
  Add offset feature to PathStyleExtension (#4126)
  Project module: support pre-projected positions (#4140)
  Repeat maps at low zoom levels (#4105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants