Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest)!: don't expose default toFake config #6288

Merged

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Aug 6, 2024

Description

This PR removes toFake from the default fakeTimers options because it forces fake methods that might not be available and leaves out methods that are actually available (like performance)

Fixes #4004

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va force-pushed the feat/dont-expose-defualt-fake-timers branch from c64f77b to 9078e3a Compare December 5, 2024 14:04
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 611bd64
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6751b3f4204943000864c199
😎 Deploy Preview https://deploy-preview-6288--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit e3144fd into vitest-dev:main Dec 5, 2024
17 checks passed
@sheremet-va sheremet-va deleted the feat/dont-expose-defualt-fake-timers branch December 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake timers don't work for performance.now()
1 participant