Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullish coalescing support #3

Closed
wants to merge 95 commits into from
Closed

Nullish coalescing support #3

wants to merge 95 commits into from

Conversation

sanex3339
Copy link

No description provided.

RReverser and others added 30 commits February 20, 2015 16:32
@RReverser
Rename AwaitExpression.delegate -> .all
fd95887
@michaelficarra
fixes estools#231: generate strings with fewer escape sequences by de…
1b3d9bc 
…fault
@michaelficarra
Merge pull request estools#232 from michaelficarra/estoolsGH-231
4842752 
fixes estools#231: generate strings with fewer escape sequences by default
@Constellation
Update esutils version
a01f670
@pgilad
update license attribute
02d47fe 
specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/
@Constellation
Merge pull request estools#235 from pgilad/patch-1
7c571e4 
update license attribute
@ef4
Support RestElement
f8bc1d5 
Closes estools#225
@Constellation
Merge pull request estools#236 from ef4/rest-element
f845b2c 
Support RestElement
@Constellation
Update node.js versions of travis
ed529d5
@ef4
Improved ArrayPattern formatting
5070077
@michaelficarra
Merge pull request estools#237 from ef4/nicer-array-patterns
2e90c2b 
Improved ArrayPattern formatting
@ef4
expand RestElement to support all patterns
7f5a86d 
This is a followup to estools#236 that brings RestElement into full spec
compliance.
@michaelficarra
Merge pull request estools#238 from ef4/expand-rest-patterns
617dc9f 
Expand RestElement to support all patterns
@michaelficarra
use "sudo: false" in travis config for faster builds
a216a16
@michaelficarra
replace * version for esprima-moz with actual version
609c969
@michaelficarra
Merge pull request estools#248 from estools/michaelficarra-patch-1
08e6f47 
use "sudo: false" in travis config for faster builds
@sterling
add support for super()
19bf5d0
@michaelficarra
Merge pull request estools#252 from sterlinghw/master
12a4319 
add support for es6 super()
@adamjmcgrath
Add support for esprima 2.x import and export statements
f2879cd
@Constellation
Merge pull request estools#253 from adamjmcgrath/esprima-2.x
dbf8fe2 
Esprima 2.x import/export statements
@tolmasky
Fix for supporting AssignmentPattern. Closes estools#229.
c3eccef 
Reviewed by @tolmasky.
@tolmasky
Add assignment pattern tests.
3fde4c3 
Reviewed by @tolmasky.
@michaelficarra
version 1.7.0
5dabbc5
@adamjmcgrath
Fix Import variable binding for esprima 2, eg `import {foo as bar} fr…
b99a200 
…om "baz";`
@Constellation
Merge pull request estools#257 from adamjmcgrath/esprima-2-aliased-im…
fc99fcd 
…ports

Fix Import variable binding for esprima 2
@ariya
Don't test esprima-moz anymore.
da47c46
@Constellation
Merge pull request estools#268 from ariya/no-moz
2a307d5 
Don't test esprima-moz anymore.
@ariya
Update semver to the latest version 5.1.
ceaa2d6
@michaelficarra
Merge pull request estools#269 from ariya/update-semver
ba5dc1c 
Update semver to the latest version 5.1.
@ariya
Travis CI's Node.js versions: exclude 0.11, add iojs and latest stabl…
5b152cf 
…e 4.

0.11 was considered unstable and superceded already by 0.12. Since >=
0.12 is what is tested, that is the one which should go in the package
manifest.
michaelficarra and others added 25 commits August 12, 2019 19:08
@michaelficarra
Version 1.12.0
124e035
@michaelficarra
Fixed missing space between for await with compact: true
2360684
@michaelficarra
Version 1.12.1
a30ea92
@TimvdLippe @michaelficarra
Update esprima to 4.0.1
819a63b
@sanex3339 @michaelficarra
Super class expression parenthesis (estools#404)
c917cf2 
* Added parenthesis for some `superClass` expressions

* Simplify logic to enable super class expression parenthesis
@sanex3339 @michaelficarra
Optional catch binding support (estools#405)
fb7b56f 
* Added support for optional-catch binding

* Reverted optional catch binding condition
@fabiosantoscode @michaelficarra
support 'regex' property when 'value' is null (estools#396)
6eb8e31
@michaelficarra
Version 1.13.0
ba40e5c
@sanex3339 @michaelficarra
Exponentiation operator (estools#407)
a25d531 
* Fixed exponentiation operator precedence

* Fixed and added test cases for LHS expression of exponentiation operator

* fix exponentiation PR

Co-authored-by: Michael Ficarra <github@michael.ficarra.me>
@michaelficarra
Version 1.14.0
86d0006
@michaelficarra
fix unnecessary parentheses for binary operators and add regression test
90f59c2
@michaelficarra
Version 1.14.1
a3b6718
@sanex3339
fixed multiline decision for object patterns with rest elements (esto…
c62cbe2 
…ols#408)

Co-authored-by: Timofey Kachalov <sanex3339@users.noreply.github.com>
Co-authored-by: sanex3339 <yarabotayuvyandex3339>
@michaelficarra
Version 1.14.2
1d85742
@brimworks
Add copyright information to LICENSE file (estools#414)
177ec89 
...matches the README.
@sanex3339
fixed precedence of sequence expression in computed property name (es…
eee573b 
…tools#415)

Co-authored-by: sanex3339 <yarabotayuvyandex3339>
@michaelficarra
Version 1.14.3
dc2993c
@sanex3339
drop support for node <6 (estools#419)
ff550a8 
Co-authored-by: sanex3339 <yarabotayuvyandex3339>
@michaelficarra
Update .gitattributes
e8e2e81
@sanex3339
add support for optional chaining (estools#412)
1d192ae 
Co-authored-by: sanex3339 <yarabotayuvyandex3339>
@michaelficarra
Version 2.0.0
ab53cd5
Nullish coalescing support
121f9a8
@sanex3339
Updated nullish coalescing logic, added more tests
5646f11
@sanex3339
Added additional check for right expression type
7f97bfa
@sanex3339
Added additional check for left expression type
6c1bd94
@sanex3339
Copy link
Author

If someone will try to resolve all conflicts, i'll be happy, I'll try to do this later

@sanex3339
Copy link
Author

sanex3339 commented Oct 31, 2020 •
edited
Loading

Seems i have to recreate all this PRs based on this wallabyjs/escodegen to prevent conflicts.
But I'll need to be sure this will be merged, not like this estools#417

@ArtemGovorov
Copy link
Member

Hey @sanex3339, Nullish coalescing support has already been implemented: c9caffb

@ArtemGovorov
Copy link
Member

Some background: this fork had been originally created for use in our products https://wallabyjs.com and https://quokkajs.com/, and while we have been maintaining it (and are planning to keep maintaining it, and adding new features, etc.), we haven't bothered to keep it up-to-date with the original repo, also tests for our changes since we've forked are located in other (closed source) repos.

If you like, please feel free to bring all the tests from the original escodegen over (including yours), because this repo is not going anywhere, will be maintained and developed and will stay open source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.