Merge upstream to master #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sending a chunked request body (hence not direct) cause AHC to crash. Motivation: Fix SslHandler position that should be before the ChunkedWriteHandler. Result: Chunked request works with HTTPS proxy.
…P tunnelling, close #1583
…r instance String) as the key type (#1587)
* add the ability to pass in a {principal name, keytab} combination to async http client.
* fix issue where spnego principal/keytab was no longer optional
* specify the login config as a map to allow all the values custom not just
a couple of them.
* remove the principal/password assertion on not null
add a map of spnego engines so you can support more than one spnego login confg per jvm
* no need to detect null on loginContext
* add a SpnegoEngine unit test.
* Delete kerberos.jaas
* Update pom.xml
* Provide more granularity to be more aligned with other http clients:
* Login context name
* Username/password auth option
* remove useless comment
* add login context name and username into the instance key
* cxf.kerby.version -> kerby.version
…lName is not specified. (#1588) * fix when servicePrincipalName is not specified. * unit test the fix.
Thanks a lo, it really helps!
* Added BlockingConnectionSemaphoreFactory * Added missing copyright to BlockingSemaphoreInfinite * Added acquireFreeChannelTimeout configuration value * Implemented acquireFreeChannelTimeout by replacing existing NonBlocking semaphores with regular Semaphores * ConnectionSemaphore tests
Fixed artifact name to `async-http-client-extras-typesafe-config`, there was a missing dash
* Errors on the request are now propagated to reactive subscribers instead of just to the request's ListenableFuture * Read timeouts can no longer occur if a reactive streams subscriber has no outstanding request. Note that this does not affect request timeouts - only read timeouts.
Fix for issue #1731. When setting the TimeoutHolder, cancel any prior timeout so that they don't leak. Previously, they would just be lost and remain in the timer until their timeout expired, which could be a long time. Previously, encountering a redirect would trigger this code, causing the old request timer to be replaced with a new one. The old timer would maintain a link back to this Future, but couldn't be canceled by this future (as its reference had been overwritten) causing the Future, is associated Response, and any AsyncResponseHandler to be retained in memory instead of being garbage collected once the request had been processed.
Add internet archive ones instead.
This Action builds and test the project without actually publishing anything when a PR is opened against master. A different action, that is triggered upon a commit to master, will actually deal with generating javadoc, documentation changes + publishing to MavenCentral.
* Bump GitHub Actions runner version to Ubuntu 20.04 * AsyncStreamHandlerTest.asyncOptionsTest - Allow for the appearance of the TRACE method in the server's response * MaxTotalConnectionTest.testMaxTotalConnections - https://github.com --> https://www.youtube.com, https://google.com --> https://www.google.com * TextMessageTest.onFailureTest - Refactor logic for more granular testing (accept ConnectException in addition to UnknownHostException, but check for "DNS Name not found" in exception cause)
* Fix typos * Fix Failing Github Actions Tests (#1753) * Bump GitHub Actions runner version to Ubuntu 20.04 * AsyncStreamHandlerTest.asyncOptionsTest - Allow for the appearance of the TRACE method in the server's response * MaxTotalConnectionTest.testMaxTotalConnections - https://github.com --> https://www.youtube.com, https://google.com --> https://www.google.com * TextMessageTest.onFailureTest - Refactor logic for more granular testing (accept ConnectException in addition to UnknownHostException, but check for "DNS Name not found" in exception cause) Co-authored-by: Tom Granot <8835035+TomGranot@users.noreply.github.com>
Specifically because Snyk's vulnerability scanner is reporting https://app.snyk.io/vuln/SNYK-JAVA-IONETTY-1020439 which is fixed in this version of Netty.
* Makes sure custom user-agent is propagated down to CONNECT requests when a proxy is in the way, ensuring all outgoing requests bear the correct user agent. * Add a test for custom user agent with proxy
Originally, when setFollowRedirect is set to true (like in Head302Test), the expected flow is HEAD --> GET (based on the behavior of Redirect30xInterceptor - see 3c25a42 for the reasoning). Following a change to the interceptor (to fix #1728), Head302Test started going on an infinite loop caused by the way the handler in the tent was set up (to account for the original HEAD --> GET flow and not the new HEAD --> HEAD --> HEAD.... flow). This commit does 3 things: * Changes Redirect30xInterceptor to set all redirects of a HEAD request to be HEADs as well * Change Head302Test to account for the new flow * Notes a flaky test in AsyncStreamHandlerTest that was found during work on the PR
* Unit test that reproduces the NPE when connection is reset by peer * Changed future.channel() to channel which is guarded to be non null * Higher request timeout because the test seems to fail regularly on Github Also the duration of running the build in Github varies Co-authored-by: Rachid Ben Moussa <rachid.benmoussa@luminis.eu>
* proxy connect custom headers * npe fix * refactor * formatting fix + version fix * npe fix * test added
First draft (WIP) of contributor technical overview. This is an incomplete document that I expect to complete more and more of over time.
Unfortunately, I'm a bit swamped at the moment, so saying I actively maintain the repo would be inaccurate. Hope to have time in the future to put some love back into the project. If anyone's interested in helping out let me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.