This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Diff between wp-fork branch and main repo's default branch #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is added because we shouldn't always use extraScrollHeight to calculate the bottom inset of the content when keyboard is open. Some unwanted bottom inset occurs if we do.
Add prop extraBottomInset to fix the unwanted bottom inset
This includes orientation change etc. We don't need to get different values for landscape/portrait modes from outside anymore.
This sometimes happens if device orientation changes
Co-Authored-By: pinarol <pinarolguc@gmail.com>
Add scroll ability relative to caret position when keyboard is open
We don't need any scrolling delay in case we trigger scroll programmatically.
We can trigger the scroll programmatically by directly calling refreshScrollForField
Open a method to refresh the scroll due to caret
We are putting a delay until caret position is available. It is probably becoming available after the height is adjusted and caret is viewable.
Fix textinput caret position, y position and height calculating wrongly
Fix waiting on caret rect detection when caret is at the end
…r-other-viewcontrollers Replace isDescendant check with a more decent one
Fix compatibility with RN 0.60.0
…lculation Fix caret scroll calculation
…h, and behind the keyboard
…raph Improve scroll calculations with caret under keyboard at mid paragraph
The exact error is:
ERROR Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.
in Unknown (at keyboard-aware-flat-list/index.ios.js:23)
This fixes the console error: currentlyFocusedField is deprecated and will be removed in a future release. Use currentlyFocusedInput
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.