generated from DTS-STN/next-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main release #128
Merged
Merged
Main release #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tus and maritalStatus, do not return GIS entitlement when partial OAS
…lt handling, field logic, normalization, country handling
…rtial oas and it's effect on gis (-1 entitilement); Added new EligibilityDetails component to DRY up some of the frontend
…us_major_refactor Add new "Partner Benefit Status" question, plus major backend refactor
… from gov site) to a single file
… or equal to" the max
* add contact service canada link to summary box * Added new html parsing functionality into the Alerts
Backend Wording
Update legal values/requirements from gov site
* Progress bar fixes and other design updates requested * use old name to remove eyesore; use a view to generate total value * Add responsive width to tooltip; fix padding in tooltip for longer tooltips; * Remove debounce from onChange handler, it only fires when the element is finsihed updating * Added new name 🎉 * Added a nextJS compliant hook for using the browsers width * tooltip bug stratching viewport fixed
- add new canadaWholeLife question - updated tests accordingly - now yearsInCanadaSince18 is only allowed when canadaWholeLife is false - cleaned up field requirement tests - add test ensuring translations exist for all questions - update frontend tooltip
Small backend fixes
* add IncomeHelper class, allows for using the correct income based on marital status * remove forbidden field check and related tests
* rebased develop * fix a bug with testing in the app * Remove extra logs * Removed localhost 🤦 * requested changes from review
* Added mobx state tree tests * DRY up the tests * updated some import issues in test and added some missing tests * Added input field tests for normal and error case * cleanup and Adding tests for the Radio component * WIP on re-enabling tests * removed some test files into a new branch, added one more progress test
* Refactoring progress and income too high to fit in the new prototype * First pass at prototype * use summary object for content of exit case for income too high * Added more info case to the review page * move the button to the bottom * Added test header * Added sticky need help, as well as dynamic links * disable the estimate and results tab when income is too high * Added 2 rows to text area in TextField * Updated button position on mobile * Fixed tests to correctly look for TEXTAREA * summary text now explains when reason is income * add contactSC link, add OAS Max Income link * update summary details texts using spreadsheet * Fixed bug with useMediaQuery when it overlapped exactly with a breakpoint * Updates from review * Fix mobile viewport bug with needhelp Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
* add additional partner questions when partnerBenefitStatus is helpMeFindOut * major refactoring to support the above * simplify allowance partner benefit status check, now just requires GIS * summary text now explains when reason is income * add more relevant reason when alw ineligible because partner not receiving gis
* Refactoring progress and income too high to fit in the new prototype * First pass at prototype * use summary object for content of exit case for income too high * move the button to the bottom * Added 2 rows to text area in TextField * Use a two column layout for all questions
* Added smooth scroll to the results page when estimate is clicked * fix null case with ref * Attempting to smooth out 🔨 the smooth scroll experience (pun intended 🤡)
…e width to the correct width from the designs! (#124)
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/AVd2BxuQhDAbHM97voiTBayvuCBZ |
…xed a bug with headless ui tabs responding to changes in mst data (#129)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've reviewed this all already, just pushing to prod to give out links to external stakeholders.