[Bug] [Demo App] Missing Accessibility Label for Image #212
Assignees
Labels
👂 acessibility
A11y issues or improvements
🐞 bug
Something isn't working
📱 demo app
Update of the Demo App
🔍 triage
A new issue that needs to be treated
Comments
Tayebsed93
added
🐞 bug
Tayebsed93
added a commit
that referenced
this issue
Nov 7, 2024
16 tasks
Tayebsed93
added a commit
that referenced
this issue
Nov 8, 2024
Tayebsed93
added a commit
that referenced
this issue
Nov 13, 2024
Tayebsed93
added a commit
that referenced
this issue
Nov 13, 2024
Tayebsed93
added a commit
that referenced
this issue
Nov 13, 2024
Tayebsed93
added a commit
that referenced
this issue
Nov 13, 2024
Tayebsed93
added a commit
that referenced
this issue
Nov 13, 2024
pylapp
added a commit
that referenced
this issue
Nov 15, 2024
Release of version 0.6.0 See below the full CHANGELOG details. Added: - [DemoApp] Update color screen to add a border on color illustration square ([#280](#280)) - [DemoApp] Add grid tokens screen in demo app ([#151](#151)) - [Tool] GitHub Action to run SwiftLint for *main* and *develop* branches Changed: - [Tool] Update `net-http` gem from 0.4.1 to 0.5.0 ([#286](#286)) - [Tool] Update `cocoapods` gem from 1.15.2 to 1.16.2 ([#286](#286)) - [Tool] Update `json` gem from 2.7.2 to 2.8.2 ([#286](#286)) - [Tool] Update `swiftformat/cli` from 0.54.3 to 0.54.6 ([#286](#286)) - [Tool] Update `Fastlane` from 2.223.1 to 2.225.0 ([#286](#286)) - [DemoApp] Update accessibility statement usage and instructions ([#278](#278)) Fixed: - [DemoApp] Add missing accessibility label for images ([#212](#212)) - [DemoApp] Fix text sizes when dynamic type is used (a11y) ([#247](#247)) Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com> Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 29, 2024
Release of version 0.7.0 See below the full CHANGELOG details. Added: - [DemoApp] Add code sample for tokens usages in token pages ([#283](#283)) - [Library] Color some new semantic tokens `colorContentStatus*`, `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*` - [Tool] Add UI tests in CI/CD pipelines ([#298](#298)) - [DemoApp] Add more UI tests on demo app ([#154](#154)) Changed: - [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*) - [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier - [DemoApp] Update space tokens screen ([#275](#275)) - [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*) - [DemoApp] Update color tokens screen - [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*) - [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*) - [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*) - [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*) - [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279)) - [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296)) Removed: - [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount` - [Library] Grid raw tokens `gridMargin900` - [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ... - [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`) - [Library] All dimension semantic tokens ([#308](#308)) Fixed: - [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285)) - [Library] Warning issues for DocC catalogs ([#293](#293)) Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com> Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com> Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com> Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Your test device
iPhone 14 Pro Max
OS Version
iOS 18
App version
v0.4.0
App orientation
Portrait
Device language
English
App language
English
Describe the issue
SwiftLint has flagged an accessibility issue: images that provide context should have an accessibility label or be explicitly hidden from accessibility. The violation occurs under the rule
accessibility_label_for_image.Please review the code and ensure that all images with contextual significance include an appropriate accessibility label, or mark them as hidden for accessibility when necessary.
SwiftLint message:
Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)Expected Behavior
This issue affects
VoiceOverusers in both theThemeSelection.swiftandShowcaseElementsPage.swiftfiles. Images without accessibility labels are not properly announced by screen readers. Adding appropriate labels ensures that VoiceOver can describe the images, providing necessary context for visually impaired users and enhancing the app’s accessibility.Example :
This ensures that the image is properly announced by screen readers, enhancing accessibility compliance and providing necessary context for visually impaired users.
Accessibility settings
This issue affects
VoiceOverusers, as images without accessibility labels will not be properly announced by screen readers. Providing an accessibility label ensures that VoiceOver can describe the image, giving context to visually impaired users and improving the overall accessibility of the app.The text was updated successfully, but these errors were encountered: