Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DemoApp] Fix VoiceOver issue with element grouping in presentation tokens (a11y) #285

Closed
1 task done
Tayebsed93 opened this issue Nov 15, 2024 · 0 comments · Fixed by #292
Closed
1 task done

[DemoApp] Fix VoiceOver issue with element grouping in presentation tokens (a11y) #285

Tayebsed93 opened this issue Nov 15, 2024 · 0 comments · Fixed by #292
Assignees
@Tayebsed93
Labels
👂 acessibility A11y issues or improvements 🐞 bug Something isn't working 📱 demo app Update of the Demo App

Comments

@Tayebsed93
Copy link
Collaborator

Prerequisites

Your test device

iPhone 14 pro MAx

OS Version

iOS 16.0

App version

0.6.0

App build number

14

App build type

DEBUG

App orientation

No response

Device language

No response

App language

No response

Describe the issue

a11y VoiceOver: Accessibility errors can be avoided by grouping elements. The idea is to vocalize the elements all at once when possible

Image

Expected Behavior

This line fixes the issue:
.accessibilityElement(children: .combine).

Image

Accessibility settings

Voice Over
@Tayebsed93 Tayebsed93 added 🐞 bug Something isn't working 👂 acessibility A11y issues or improvements 📱 demo app Update of the Demo App 🔍 triage A new issue that needs to be treated labels Nov 15, 2024
@Tayebsed93 Tayebsed93 moved this from Triage to In Progress in [OUDS] Project Nov 15, 2024
@Tayebsed93 Tayebsed93 self-assigned this Nov 15, 2024
@Tayebsed93 Tayebsed93 linked a pull request Nov 15, 2024 that will close this issue
[#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app #292
Merged
16 tasks
@Tayebsed93 Tayebsed93 moved this from In Progress to In Review in [OUDS] Project Nov 15, 2024
@pylapp pylapp removed the 🔍 triage A new issue that needs to be treated label Nov 18, 2024
pylapp pushed a commit that referenced this issue Nov 20, 2024
@Tayebsed93
fix: VoiceOver issue with element grouping in presentation tokens for…
b2c5ce3 
… demo app (#285) (#292)

Updates also accessibility statement after that fix.

Reviewed-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in [OUDS] Project Nov 20, 2024
@pylapp pylapp mentioned this issue Nov 29, 2024
Merged
pylapp added a commit that referenced this issue Nov 29, 2024
@pylapp @ludovic35
@Tayebsed93 @boosted-bot
Version 0.7.0 (#324)
7463f43 
Release of version 0.7.0
See below the full CHANGELOG details.

Added:
- [DemoApp] Add code sample for tokens usages in token pages ([#283](#283))
- [Library] Color some new semantic tokens `colorContentStatus*`,  `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*`
- [Tool] Add UI tests in CI/CD pipelines ([#298](#298))
- [DemoApp] Add more UI tests on demo app ([#154](#154))

Changed:
- [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*)
- [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier 
- [DemoApp] Update space tokens screen ([#275](#275))
- [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*)
- [DemoApp] Update color tokens screen 
- [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*)
- [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*)
- [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*)
- [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*)
- [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279))
- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296))

Removed:
- [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount`
- [Library] Grid raw tokens `gridMargin900`
- [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ...
- [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`)
- [Library] All dimension semantic tokens ([#308](#308))

Fixed:
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285))
- [Library] Warning issues for DocC catalogs ([#293](#293))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tayebsed93 Tayebsed93

Labels
👂 acessibility A11y issues or improvements 🐞 bug Something isn't working 📱 demo app Update of the Demo App
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
3 participants
@pylapp @ludovic35 @Tayebsed93