Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DemoApp] Update space token screen #275

Closed
1 task done
ludovic35 opened this issue Nov 7, 2024 · 2 comments · Fixed by #303
Closed
1 task done

[DemoApp] Update space token screen #275

ludovic35 opened this issue Nov 7, 2024 · 2 comments · Fixed by #303
Assignees
@pylapp @ludovic35 @Tayebsed93
Labels
📱 demo app Update of the Demo App

Comments

@ludovic35
Copy link
Member

ludovic35 commented Nov 7, 2024 •
edited
Loading

Prerequisites

As a

Developer

... I want to

illustrate all tokens

... so that I can

see the result

Motivation and context

  • On space screen : add missing tokens
  • On space screen: add illustration with text for all sections in screen

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Nov 7, 2024
@ludovic35 ludovic35 added 📱 demo app Update of the Demo App and removed 🔍 triage A new issue that needs to be treated labels Nov 14, 2024
@ludovic35 ludovic35 linked a pull request Nov 25, 2024 that will close this issue
[#275] Update space tokens screen in DemoApp #303
Merged
13 tasks
@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 25, 2024

@ludovic35 where can I test this, I do not see any Alpha version associated to this issue?

@pylapp
Copy link
Member

pylapp commented Nov 25, 2024 •
edited
Loading

@B3nz01d As discussed previously, the task is not in the "in review" column project which means this issue is not ready to be validated by PO / a11y team / design team.
In addition you can see the associated pull request is in draft mode which means it should not be merged even be reviewed yet. Furthermore there is no review done on the PR, which is a mandatory condition to have the issue moved from "in progress" column to "in review". We agreed to work with this process. That is the reason why there is no alpha build. Otherwise a GitHub comment should be available here.

@ludovic35 ludovic35 mentioned this issue Nov 27, 2024
Merged
13 tasks
@ludovic35 ludovic35 moved this from In Progress to In Review in [OUDS] Project Nov 27, 2024
pylapp pushed a commit that referenced this issue Nov 28, 2024
@ludovic35
refactor: update space tokens screen in demo app (#275) (#303)
4baef6c 
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in [OUDS] Project Nov 28, 2024
@pylapp pylapp mentioned this issue Nov 29, 2024
Merged
pylapp added a commit that referenced this issue Nov 29, 2024
@pylapp @ludovic35
@Tayebsed93 @boosted-bot
Version 0.7.0 (#324)
7463f43 
Release of version 0.7.0
See below the full CHANGELOG details.

Added:
- [DemoApp] Add code sample for tokens usages in token pages ([#283](#283))
- [Library] Color some new semantic tokens `colorContentStatus*`,  `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*`
- [Tool] Add UI tests in CI/CD pipelines ([#298](#298))
- [DemoApp] Add more UI tests on demo app ([#154](#154))

Changed:
- [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*)
- [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier 
- [DemoApp] Update space tokens screen ([#275](#275))
- [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*)
- [DemoApp] Update color tokens screen 
- [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*)
- [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*)
- [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*)
- [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*)
- [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279))
- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296))

Removed:
- [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount`
- [Library] Grid raw tokens `gridMargin900`
- [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ...
- [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`)
- [Library] All dimension semantic tokens ([#308](#308))

Fixed:
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285))
- [Library] Warning issues for DocC catalogs ([#293](#293))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

@ludovic35 ludovic35

@Tayebsed93 Tayebsed93

Labels
📱 demo app Update of the Demo App
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#275] Update space tokens screen in DemoApp Orange-OpenSource/ouds-ios
4 participants
@pylapp @ludovic35 @Tayebsed93 @B3nz01d