-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tokens] Improve Multiple
-based objects for tokenator
values integration
#279
Labels
📀 token
Related to tokens (raws, semantics or components)
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pylapp
added a commit
that referenced
this issue
Nov 20, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 20, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 20, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 20, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
12 tasks
12 tasks
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
pylapp
added a commit
that referenced
this issue
Nov 21, 2024
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Today, the Figma kit defined by the design team exposed plenty of tokens, and some of these tokens are quite particular.
Indeed, we may have tokens for which the values rely on the color scheme (dark or light modes) or the size class (compact or regular).
However, they are until now considered as one token, but quite dynamic with multiple values.
To prevent users to have to deal with lots of tokens declinations, we choose to define
Multiple*
objects so as to contain pair of values ; depending to the token it will contain values for compact and regular size classes or light and dark color schemes. Thus, we will be able through the themes to expose one object with the two values available, as a "multiple token"/. The Android team uses also the same logic.However, the Figma tool is not able to manage such configurations (and also composite values), so the tokenator converting its JSON to Swift won't be able to build such
Multiple*
objects. So the solution we agreed with @julien-deramond is the following one:Thus, having
Multiple*
objects will help us to test the tokens (i.e. ensure values are the expected one depending to configuration, mainly forInverseTheme
) and also provide one "fake" token with the two possibles values, through the theme.Today we have tokens depending to size class:
MultipleSpaceTokens
MultipleSizeTokens
MultipleFontLetterSpacingTokens
MultipleFontSizeTokens
MultipleFontLineHeightTokens
MultipleTypographyTokens
We have also tokens depending to color schemes:
MultipleColorTokens
MultipleElevationTokens
(because of box shadow)Note this is the same logic for composite tokens where the notion of "composite" does not exist in Figma, but invented by the design team, so the ¨tokenator* cannot provide the Swift cod ebecause the JSON it processes doe snot contin such objects. Composites are defined manualy based on generated tokens.
Definition of Ready
Definition of Done (iOS team only)
OUDSTheme+ElevationMultipleSemanticTokens
TypographyCompositeSemanticTokens
won't be uopdate by tokenator)Following types must be updated:
MultipleSpaceTokens
MultipleSizeTokens
MultipleFontLetterSpacingTokens
MultipleFontSizeTokens
MultipleFontLineHeightTokens
MultipleTypographyTokens
MultipleColorTokens
MultipleElevationTokens
draft.zip
The text was updated successfully, but these errors were encountered: