Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DemoApp] Add code example to show how to use token #283

Closed
1 task done
ludovic35 opened this issue Nov 15, 2024 · 5 comments · Fixed by #297
Closed
1 task done

[DemoApp] Add code example to show how to use token #283

ludovic35 opened this issue Nov 15, 2024 · 5 comments · Fixed by #297
Assignees
@pylapp @Tayebsed93
Labels
📱 demo app Update of the Demo App 👌 OK Accessibility A11Y review has been done

Comments

@ludovic35
Copy link
Member

Prerequisites

As a

user of the Library

... I want to

see the code of a token usage

... so that I can

use it directly

Motivation and context

See the design in figma.
All token screens should have this illustration
Image

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Nov 15, 2024
@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Nov 15, 2024
@ludovic35 ludovic35 added the 📱 demo app Update of the Demo App label Nov 15, 2024
@Tayebsed93 Tayebsed93 self-assigned this Nov 15, 2024
@Tayebsed93 Tayebsed93 moved this from Todo to In Progress in [OUDS] Project Nov 18, 2024
@Tayebsed93 Tayebsed93 linked a pull request Nov 19, 2024 that will close this issue
[#283] Add code example to show how to use token in tokens pages of demo app #297
Merged
16 tasks
@pylapp pylapp mentioned this issue Nov 21, 2024
Merged
16 tasks
@Tayebsed93 Tayebsed93 added the 👌 OK Accessibility A11Y review has been done label Nov 21, 2024
@pylapp pylapp moved this from In Progress to In Review in [OUDS] Project Nov 21, 2024
@pylapp
Copy link
Member

pylapp commented Nov 21, 2024 •
edited
Loading

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (283)
  • Version: 0.7.0
  • Build number: 1732201889
  • Build tag: 19b5e5e
  • Build type: ALPHA
  • Build details (GitHub): 283

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 @Tayebsed93 (dev team)
cc @TonyAntonyHello @mccart77 @MaximeTonnerre (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@pylapp pylapp removed the 🔍 triage A new issue that needs to be treated label Nov 21, 2024
@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 22, 2024 •
edited
Loading

@Tayebsed93 When interacting with the "View token code example" to reduce it, when it is reduced it does not show the chevron anymore.

The behavior should be this when opened
Image

and this when closed:
Image

And the default when you open the page should be with the closed version

Also the code exemple is not the token itself onle, it's how you use it in the code. ie: "theme.borderWidthDefault" or "theme.colorBgPrimary.color(for: colorScheme)" or "theme.spaceScaledMedium.dimension(for: horizontalSizeClass)"

And last but not least when the screen text size is raised to 190 the code title is changing but is not aligned anymore and the code part did not change size.
Image

@B3nz01d B3nz01d moved this from In Review to In Progress in [OUDS] Project Nov 22, 2024
@pylapp pylapp moved this from In Progress to In Review in [OUDS] Project Nov 25, 2024
@pylapp
Copy link
Member

pylapp commented Nov 25, 2024

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (283)
  • Version: 0.7.0
  • Build number: 1732544513
  • Build tag: a317daa
  • Build type: ALPHA
  • Build details (GitHub): 283

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 @Tayebsed93 (dev team)
cc TonyAntonyHello @mccart77 @MaximeTonnerre (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

@pylapp
Copy link
Member

pylapp commented Nov 25, 2024

@B3nz01d That build needs your review ;-)

@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 27, 2024

as described in the previous comment: "the default when you open the page should be with the closed version"

@B3nz01d B3nz01d moved this from In Review to In Progress in [OUDS] Project Nov 27, 2024
@ludovic35 ludovic35 moved this from In Progress to In Review in [OUDS] Project Nov 27, 2024
pylapp pushed a commit that referenced this issue Nov 29, 2024
@Tayebsed93 @ludovic35
feat: add code samples to show how to use token in tokens pages of de…
dcd69ea 
…mo app (#283) (#297)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic PINEL <ludovic.pinel@orange.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in [OUDS] Project Nov 29, 2024
@pylapp pylapp mentioned this issue Nov 29, 2024
Merged
pylapp added a commit that referenced this issue Nov 29, 2024
@pylapp @ludovic35
@Tayebsed93 @boosted-bot
Version 0.7.0 (#324)
7463f43 
Release of version 0.7.0
See below the full CHANGELOG details.

Added:
- [DemoApp] Add code sample for tokens usages in token pages ([#283](#283))
- [Library] Color some new semantic tokens `colorContentStatus*`,  `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*`
- [Tool] Add UI tests in CI/CD pipelines ([#298](#298))
- [DemoApp] Add more UI tests on demo app ([#154](#154))

Changed:
- [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*)
- [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier 
- [DemoApp] Update space tokens screen ([#275](#275))
- [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*)
- [DemoApp] Update color tokens screen 
- [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*)
- [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*)
- [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*)
- [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*)
- [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279))
- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296))

Removed:
- [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount`
- [Library] Grid raw tokens `gridMargin900`
- [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ...
- [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`)
- [Library] All dimension semantic tokens ([#308](#308))

Fixed:
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285))
- [Library] Warning issues for DocC catalogs ([#293](#293))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

@Tayebsed93 Tayebsed93

Labels
📱 demo app Update of the Demo App 👌 OK Accessibility A11Y review has been done
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
4 participants
@pylapp @ludovic35 @Tayebsed93 @B3nz01d