Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tools] Update UI tests and CI/CD pipelines #298

Closed
5 tasks done
pylapp opened this issue Nov 20, 2024 · 4 comments · Fixed by #304
Closed
5 tasks done

[Tools] Update UI tests and CI/CD pipelines #298

pylapp opened this issue Nov 20, 2024 · 4 comments · Fixed by #304
Assignees
@pylapp
Labels
🔨 tool Related to tooling

Comments

@pylapp
Copy link
Member

pylapp commented Nov 20, 2024 •
edited
Loading

Description

Since we have now UI-based uniy tests thanks to the nice work of @Tayebsed93 we may need to update these unit tests to ensure no tokens are missing in the tests pools.
In addition, CI/CD chains should be updated so as to run tests in our pipelines.

Definition of Done

  • If needed, update UI test classes
  • Define new Fastlane lane running these UI unit tests
  • Update GitHub Actions workflows to run these tests using the new lane
  • Update GitLab CI workflows to run these tests using the new lane
  • Update the wiki if relevant
@pylapp pylapp added the 🔨 tool Related to tooling label Nov 20, 2024
@pylapp pylapp self-assigned this Nov 20, 2024
@pylapp pylapp changed the title [Tools] Update UI tests and CI/CD [Tools] Update UI tests and CI/CD pipelines Nov 20, 2024
@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Nov 20, 2024
pylapp added a commit that referenced this issue Nov 25, 2024
@pylapp
refactor(Fastfile): change device for tests (#298)
c8bf344 
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp moved this from Todo to In Progress in [OUDS] Project Nov 25, 2024
@pylapp
Copy link
Member Author

pylapp commented Nov 25, 2024

Note that even if we have semantic tokens for dimensions and grids, nothing is displayed as views or effects in the demo app because these tokens today are only raw values. So no need to have UI tests for them.

@pylapp
Copy link
Member Author

pylapp commented Nov 25, 2024

📣 New TestFlight ALPHA upload available 🚀

Please, get the new build from TestFlight app, or contact the project maintainers (@ludovic35 or @pylapp) to get access.

  • Display name: OUDS Showcase ALPHA (298)
  • Version: 0.7.0
  • Build number: 1732547821
  • Build tag: 229f2fd
  • Build type: ALPHA
  • Build details (GitHub): 298

cc @B3nz01d (product owner)
cc @pylapp @ludovic35 @Tayebsed93 (dev team)
cc @TonyAntonyHello @mccart77 @MaximeTonnerre (design team)

This is an automated message sent with love thanks to Fastlane from our CI/CD pipeline 🤘

pylapp added a commit that referenced this issue Nov 25, 2024
@pylapp
refactor(Fastfile): change device for tests (#298)
3f4244f 
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp linked a pull request Nov 25, 2024 that will close this issue
[#298] Update tests and CI/CD pipelines #304
Merged
pylapp added a commit that referenced this issue Nov 25, 2024
@pylapp
test: improve unit and UI tests and enrich CI/CD pipelines (#298) (#304)
fd61036 
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Nov 25, 2024
@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 25, 2024

I do not think I can validate this one @pylapp?

@pylapp
Copy link
Member Author

pylapp commented Nov 25, 2024

No need, that what an alpha build to test the evolutions in our CI/CD pipeline. In most of cases you see a "tool"-related pull request you can ignore it. In addition the issue is closed, so it does not expect to have any more review.

@pylapp pylapp mentioned this issue Nov 29, 2024
Merged
pylapp added a commit that referenced this issue Nov 29, 2024
@pylapp @ludovic35
@Tayebsed93 @boosted-bot
Version 0.7.0 (#324)
7463f43 
Release of version 0.7.0
See below the full CHANGELOG details.

Added:
- [DemoApp] Add code sample for tokens usages in token pages ([#283](#283))
- [Library] Color some new semantic tokens `colorContentStatus*`,  `colorContentOnBrand*`, `colorContentOnStatus*`, `colorGradient*`, `colorBorder*`, `colorContentOnAction*`
- [Tool] Add UI tests in CI/CD pipelines ([#298](#298))
- [DemoApp] Add more UI tests on demo app ([#154](#154))

Changed:
- [Library] Update `GridSemanticTokens` tokens (tokenator *20241129080807*)
- [Library] Types `GridExtraCompactSemanticToken`, `GridCompactSemanticToken` and `GridRegularSemanticToken` replaced by `GridSemanticToken` to make tokenator updates integration easier 
- [DemoApp] Update space tokens screen ([#275](#275))
- [Library] Update `GridRawTokens` tokens (tokenator *20241128161629*)
- [DemoApp] Update color tokens screen 
- [Library] Update `ColorSemanticTokens` tokens (tokenator *20241127112301*)
- [Library] Update `SpaceSemanticTokens` tokens (tokenator *20241127074206*)
- [Library] Update `SizeSemanticTokens` with rename of tokens (tokenator *20241126134156*)
- [Library] Update `ElevationSemanticTokens` (tokenator *20241126120657*)
- [Library] Improve Multiple-based objects for tokenator values integration ([#279](#279))
- [Tool] Use `macos-15` runner for GitHub Actions builds ([#296](#296))

Removed:
- [Library] Grid semantic tokens `gridExtraCompactColumnCount`, `gridCompactColumnCount` and `gridRegularColumnCount`
- [Library] Grid raw tokens `gridMargin900`
- [Library] Color semantic tokens `colorContentOnBg*`, `colorBorderOnBg*`, `colorBorderStatus*`, some `colorAction*OnBg*`, `colorDecorative{Primary,Secondary,Tertiary}`, `colorAlwaysOnBg*`, `colorBgBrand{Secondary,Tertiary}`, `colorContentBrand{Secondary,Tertiary}`, `colorBorderBrand{Secondary,Tertiary}`, `colorContentStatusAccent`, ...
- [Library] Some space semantic tokens type aliases to help tokenator job (`SpacePaddingInlineSemanticToken`, `SpacePaddingBlockSemanticToken`, `SpaceGapInlineSemanticToken`, `SpaceGapStackSemanticToken`)
- [Library] All dimension semantic tokens ([#308](#308))

Fixed:
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens and update accessibility statement ([#212](#285))
- [Library] Warning issues for DocC catalogs ([#293](#293))

Co-authored-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Co-authored-by: Ludovic Pinel <ludovic.pinel@orange.com>
Co-authored-by: Tayeb Sedraia <tayeb.sedraia@orange.com>
Co-authored-by: boosted-bot <boosted-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🔨 tool Related to tooling
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#298] Update tests and CI/CD pipelines Orange-OpenSource/ouds-ios
2 participants
@pylapp @B3nz01d