Remove everything in the attic #13889
Conversation
|
Soooo excited!!! |
|
+@EricCousineau-TRI would you like to review this over the next week? The changes other than pure deletions relate to build system and pydrake doc / shared library integration. |
There was a problem hiding this comment.
Just reviewed all non-deletions. Looks good!
Reviewed 12 of 387 files at r1.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers, labeled "do not merge" (waiting on @EricCousineau-TRI)
There was a problem hiding this comment.
Blindly marked all deletions as reviewed.
Reviewed 375 of 387 files at r1.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge"
There was a problem hiding this comment.
Wow. So many person hours of work being retired in the PR. What a milestone!
Will we have a "last SHA with attic" tag to make it easier to go back and look for any lost technology that might still be up there?
Reviewable status: needs at least two assigned reviewers, labeled "do not merge"
As a workaround, you could do |
There was a problem hiding this comment.
Nice. I didn't realize that would work for paths that no longer exist.
Reviewable status: needs at least two assigned reviewers, labeled "do not merge"
|
The linked issue talks about making a tag. It might still be a good idea. However, also note that all of v0.10 through v0.22 release tags also have the attic code. Posting that in the issue might be good enough. We can also always go back and make a tag later, it doesn't have to be concurrent with the merge. |
|
@drake-jenkins-bot retest this please |
jwnimmer-tri
added
status: single reviewer ok
|
Woo hoo! |
Closes #12158.
This change is