Skip to content

Conversation

@TomWayne98
Copy link
Owner

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

SUPERCILEX and others added 30 commits February 23, 2017 09:47
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Correct button colors + hide appbar on AuthPicker screen
Finish the KickOffActivity on dialog tap outside
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
All layouts are fully accesible
…Changed

# Conflicts:
#	database/src/main/java/com/firebase/ui/database/FirebaseIndexArray.java
update support library -> 25.3.0
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
samtstern and others added 29 commits June 7, 2017 16:00
Change-Id: I5ff1752f718b91602020147a91fe56691b09318f
Change-Id: I0b884bdbe5e62713dc3a4edca8539cace74f3f18
Change-Id: If1686bde8906f2e06d87c51fb8399be0b960028d
Change-Id: I6eac4c2e92c13b1e5ad9a2953441566ad2d7c29e
Merge phone auth into version-2.0.0
Change-Id: Ib65f67b63052ee3a0cf542a38931610208abbd9f
Change-Id: I661d5f056c292b2679be1921e972366810cef2ee
Change-Id: Ibe0bfa105b5e316b992552727df0e6167c10cf56
)

All examples of the `new Chat(...)` constructor being used in the code assume the message is the 3rd parameter passed to the constructor and not the 2nd.
typo : 
PROVDER -> PROVIDER
# Conflicts:
#	.gitignore

#	auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

#	auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java
#	auth/src/main/res/drawable/idp_button_background_email.xml
#	auth/src/main/res/layout-land/auth_method_picker_layout.xml
#	auth/src/main/res/layout/activity_register_email.xml
#	auth/src/main/res/layout/auth_method_picker_layout.xml
#	auth/src/main/res/layout/check_email_layout.xml
#	auth/src/main/res/layout/forgot_password_layout.xml
#	auth/src/main/res/layout/idp_button_facebook.xml
#	auth/src/main/res/layout/idp_button_google.xml
#	auth/src/main/res/layout/idp_button_twitter.xml
#	auth/src/main/res/layout/register_email_layout.xml
#	auth/src/main/res/layout/welcome_back_idp_prompt_layout.xml
#	auth/src/main/res/layout/welcome_back_password_prompt_layout.xml
#	auth/src/main/res/values/colors.xml
#	auth/src/main/res/values/strings.xml
#	auth/src/main/res/values/styles.xml
#	constants.gradle
@TomWayne98 TomWayne98 merged commit 1ae2db4 into master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.