r/db event subscription: set source type when updating categories

…ity, and role_arn attributes

This is the AWS provider, so we should probably use AWS examples

This provider is no longer in the core repo, so this document does not relate to core features

r/aws_ecs_cluster: support resource import

…o-v1.12.60

Bump aws-sdk-go to v1.12.60

Update Contributing document

…ue. (hashicorp#2777)

* d/aws_ssm_parameter: Support returning raw encrypted SecureString value.

It is useful to have it for triggers or other purposes. Defaults to
returning decrypted value as before.

* d/aws_ssm_parameter: Simplify test case.

I think there is no need to add another test case just for in parameter
check. Simply randomize it to be 100% sure.

* Make test deterministic

…ormatting-and-links

docs: Fix formatting & add missing links

…0-entry

CHANGELOG: Fix link to 1.7.0 released hashicorp#2082

Add postgres example to aurora documentation

… reduce chances for panic

The previous phrase "AWS only supports VPC peering within the same AWS region." existed in the documentation, it's no longer accurate since hashicorp#2508 opened up multi-regional peering capabilities and was merged and released in provider version 1.7.

Update documentation to reflect external regional peering.

… checks

Fixes hashicorp#2978 "Validation forces invalid path for TCP health check" 

Currently the validation forces the health check path to begin with a slash("/"), even when the protocol is TCP, in which case the health check path must be blank. The validation is preventing valid use cases. 

Since this validation can only check the one field on its own, the check is amended to only validate the path begins with a "/" if the path is not blank. Note that when the path is blank, it is not passed to AWS at all (see lines 226-228), so I think this change does not weaken validation.

…-go-v1.12.61

Bump aws-sdk-go to v1.12.61

Cross-region peering does not support the auto_accept attribute.

…apshot-in-progress

data-source/aws_db_snaphost: Prevent crash on unfinished snapshots

[RFC] Code Style and Schema Structure

…o-v1.12.62

Bump aws-sdk-go to v1.12.62

Docs: Fix aws_vpc_peering_connection example

* Adjust ordering of disassociate/associate boolean logic for readability
* Remove extraneous boolean parenthesis

…line-empty-artifacts

resource/aws_codepipeline: Prevent crash on empty artifacts

…no-tags-disassociation

r/aws_eip: Do not disassociate on tags-only update

…topic_subscription-panic

r/aws_sns_topic_subscription: Use ForceNew instead of custom logic to reduce chances for panic

…terraform-provider-aws into b-aws_iam_user-update-id

…hicorp#2979

…ec and location

Also simplifies flattenAwsCodebuildProjectSource and moves Set Hash declarations to schema

resource/aws_lb_target_group: Allow a blank health check path, for TCP healtchecks

…e policies with same name

…calingPolicy when not found

…=false.

resource/aws_iam_instance_profile: Fix bug preventing destruction with -refresh…

Metric aggregation type is optional, but displayed in the docs as required.

docs/r/appautoscaling_policy: minor fix

…policies with same name

…utoscaling_policy-precise-get

resource/aws_appautoscaling_policy: Match correct policy when multiple policies with same name

…ing source state

…build_project-source-crash-fix

resource/aws_codebuild_project: Prevent crash on empty source buildspec and location

hashicorp#2970)

* Fix kinesis firehose stream breaking for s3 destinations
- import doesn't work for s3 destination

* Run tests for extended_s3 config

* Fix invalid test config

* Avoid crash on empty redshift's S3BackupDescription

Fixes hashicorp#3006

* Fix flattenProcessingConfiguration

Flattener was previously broken, hence drifts were not detected.
Adding an error check should prevent breaking it in the future.

* Filter out default params in processing configuration

Firehose API automatically sets some default parameters
which we need to filter out to prevent diffs during routine
use of the resource.

* Suppress diff for redshift_configuration.0.password

* Replace string with constant

… and validate JSON

This also refactors the acceptance testing to check attributes and reuse test configurations.

…rom acceptance testing

…otDisabled

…ibute test

…urityGroupRule_ExpectInvalidTypeError

…ction-configuration

resource/aws_lambda_function: Make rate limit errors retryable

…y-creation

resource/aws_emr_cluster: Retry creation on ValidationException (IAM)

…ain-fix

test/aws_api_gateway_*: Fix invalid domain

… CW logging opts

…d.Id() value for readability

…user_policy-multiple-fixes

resource/aws_iam_user_policy: Fix updates with generated policy names and validate JSON

…scaling_schedule-start-end

resource/aws_autoscaling_schedule: Remove hardcoded start/end times from acceptance testing

…dfront_distribution-delete-retries

resource/aws_cloudfront_distribution: Retry deletion on DistributionNotDisabled

…ecurity_group-pin-us-east-1

resource/aws_db_security_group: Randomize acceptance test group name

…rity_group_rule-fix-test-typo

resource/aws_security_group_rule: Fix regex escaping in TestAccAWSSecurityGroupRule_ExpectInvalidTypeError

r/iam_role: Use ListAttachedRolePoliciesPages